RepoMirrors/mpv
1
0
Fork 0
mirror of https://github.com/mpv-player/mpv synced 2025-03-23 20:00:56 +00:00
Code Issues Releases Wiki Activity

Add a comment on shift vs. division

Browse Source 
git-svn-id: svn://svn.mplayerhq.hu/mplayer/trunk@27259 b3059339-0415-0410-9bf9-f77b7e298cf2
This commit is contained in:
reimar 2008-07-11 19:00:49 +00:00
parent 68e6f22bbc
commit ffc22175d3
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libmpcodecs/ad_msadpcm.c
View File

@ -171,6 +171,9 @@ static int ms_adpcm_decode_block(unsigned short *output, unsigned char *input,
upper_nibble ^= 1; upper_nibble ^= 1;
SE_4BIT(snibble); SE_4BIT(snibble);
// should this really be a division and not a shift?
// coefficients were originally scaled by for, which might have
// been an optimization for 8-bit CPUs _if_ a shift is correct
predictor = ( predictor = (
((sample1[current_channel] * coeff1[current_channel]) + ((sample1[current_channel] * coeff1[current_channel]) +
(sample2[current_channel] * coeff2[current_channel])) / 64) + (sample2[current_channel] * coeff2[current_channel])) / 64) +