RepoMirrors
/
mpv
mirror of https://github.com/mpv-player/mpv
1
0
Fork 0
Code Issues Releases Wiki Activity

Some further explanations, dev-eng is now subscribers only. 

git-svn-id: svn://svn.mplayerhq.hu/mplayer/trunk@7646 b3059339-0415-0410-9bf9-f77b7e298cf2
This commit is contained in:
diego 2002-10-07 00:46:57 +00:00
parent c7d917b726
commit fd146f515a
1 changed files with 22 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
DOCS/tech/patches.txt
View File

@ -1,11 +1,14 @@
Sending patches: Sending patches:
~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~
Note: We know these rules are hard, but it's hard to maintain such a
big and complex project, so you should accept our rules. We have no
time for fixing buggy, broken or old patches!
1. Always make patches for the CVS version. Note: We know our rules place a burden on you, but rest assured that
We do not accept patches for old versions or releases. maintaining a big and complex software project is even harder, so please
accept our rules. We cannot afford to spend our time fixing buggy, broken or
outdated patches.
1. Always make patches for the CVS version. The README describes how to check
out CVS and daily CVS snapshots are available from our download page.
We do not accept patches for releases or outdated CVS versions.
2. Make unified diffs ('diff -Naur' or 'cvs diff -u'). 2. Make unified diffs ('diff -Naur' or 'cvs diff -u').
@ -18,21 +21,24 @@ time for fixing buggy, broken or old patches!
5. Comment parts that really need it (tricky side-effects etc). 5. Comment parts that really need it (tricky side-effects etc).
Commenting trivial code not required. Comments must be English! Commenting trivial code not required. Comments must be English!
6. Do not ask for CVS write access at first time. If you contributed 6. Send your patch to the mplayer-dev-eng mailing list as a base64-encoded
1 or more nice, acceptable patches and they need maintaining or attachment (use gzip or bzip2 *only* if it's bigger than 80k or if you know
you want to be an mplayer developer, you'll get CVS write access. that your mailer messes up (reformats) text attachments) with the subject
line: '[PATCH] very short description of the patch'.
7. Subscribe to the mplayer-dev-eng list (don't worry, it's low traffic)
and send your patch there as base64-encoded attachment (use gzip or
bzip2 *only* if it's really big or if you know that your mailer messes
up (reformats) text attachments).
Subject line should be: '[PATCH] very short description of the patch'.
In the mail, describe in a few sentences what you change and why. In the mail, describe in a few sentences what you change and why.
If you made independent changes, try to send them as separate patches. If you made independent changes, try to send them as separate patches.
The subject line is very important if you do not want your patch to get The subject line is very important if you do not want your patch to get
lost in the noise. We need the uppercase [PATCH] to be able to search lost in the noise. We need the uppercase [PATCH] to be able to search
for unapplied patches, so please use it. for unapplied patches, so please use it.
You have to subscribe to mplayer-dev-eng since we blocked postings from
non-subscribers after spam problems and because patches get reviewed by the
developers on the list. We want you to be available for discussing your
code, you might be asked to make modifications before we accept it. Don't
worry, mplayer-dev-eng is not high traffic and you can subscribe with the
nomail option if you do not wish to receive all the mails.
7. Do not immediately ask for CVS write access. If you contributed one or more
nice, acceptable patches and they need maintaining or you want to be an
MPlayer developer, you'll get CVS write access.
Thank you! Thank you!
A'rpi