RepoMirrors
/
mpv
mirror of https://github.com/mpv-player/mpv
1
0
Fork 0
Code Issues Releases Wiki Activity

filter: fix potential NULL pointer deref 

The rest of the function should be executed only if both are set. It
seems like in practice this didn't happen yet with only one of them
unset, but in theory it's possible. Found by Coverity.
This commit is contained in:
wm4 2018-02-14 23:19:26 +01:00 committed by Kevin Mitchell
parent a2cf846a5c
commit fca64d913b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
filters/filter.c
View File

@ -325,7 +325,7 @@ static void init_connection(struct mp_pin *p)
// manual connections at the ends is still disconnected (or if this // manual connections at the ends is still disconnected (or if this
// attempted to extend an existing connection, becomes dangling and gets // attempted to extend an existing connection, becomes dangling and gets
// disconnected). // disconnected).
if (!in->manual_connection && !out->manual_connection) if (!in->manual_connection || !out->manual_connection)
return; return;
assert(in->dir == MP_PIN_IN); assert(in->dir == MP_PIN_IN);