RepoMirrors
/
mpv
mirror of https://github.com/mpv-player/mpv
1
0
Fork 0
Code Issues Releases Wiki Activity

tests: stop comparing floats against DBL_EPSILON, use FLT_EPSILON 

Fixes #5253.
This commit is contained in:
Ilya Tumaykin 2018-02-01 14:05:06 +03:00 committed by Kevin Mitchell
parent d7db42d27f
commit f4f24c105f
No known key found for this signature in database
GPG Key ID: 559A34B46A917232
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/gl_video.c
View File

@ -4,22 +4,22 @@
static void test_scale_ambient_lux_limits(void **state) {
float x;
x = gl_video_scale_ambient_lux(16.0, 64.0, 2.40, 1.961, 16.0);
assert_double_equal(x, 2.40f);
assert_float_equal(x, 2.40f);
x = gl_video_scale_ambient_lux(16.0, 64.0, 2.40, 1.961, 64.0);
assert_double_equal(x, 1.961f);
assert_float_equal(x, 1.961f);
}
static void test_scale_ambient_lux_sign(void **state) {
float x;
x = gl_video_scale_ambient_lux(16.0, 64.0, 1.961, 2.40, 64.0);
assert_double_equal(x, 2.40f);
assert_float_equal(x, 2.40f);
}
static void test_scale_ambient_lux_clamping(void **state) {
float x;
x = gl_video_scale_ambient_lux(16.0, 64.0, 2.40, 1.961, 0.0);
assert_double_equal(x, 2.40f);
assert_float_equal(x, 2.40f);
}
static void test_scale_ambient_lux_log10_midpoint(void **state) {
@ -27,7 +27,7 @@ static void test_scale_ambient_lux_log10_midpoint(void **state) {
// 32 corresponds to the the midpoint after converting lux to the log10 scale
x = gl_video_scale_ambient_lux(16.0, 64.0, 2.40, 1.961, 32.0);
float mid_gamma = (2.40 - 1.961) / 2 + 1.961;
assert_double_equal(x, mid_gamma);
assert_float_equal(x, mid_gamma);
}
int main(void) {

3
test/test_helpers.h
View File

@ -10,6 +10,7 @@
#include <math.h>
#include <float.h>
#define assert_double_equal(a, b) assert_true(fabs(a - b) <= DBL_EPSILON)
#define assert_double_equal(a, b) assert_true(fabs((a) - (b)) <= DBL_EPSILON * fmax(fabs(a), fabs(b)))
#define assert_float_equal(a, b) assert_true(fabsf((a) - (b)) <= FLT_EPSILON * fmaxf(fabsf(a), fabsf(b)))
#endif