RepoMirrors
/
mpv
mirror of https://github.com/mpv-player/mpv
1
0
Fork 0
Code Issues Releases Wiki Activity

fuzzer: stop player after 5 seconds of playback 

Timeouts can happen with various conditions, big, slow to decode files
is one of them. Most of the time those timeouts are not really important
to "fix". While they may show some issues like we currently have with
audio EOF #14427 for ao-null-untimed. Most of the reports are completely
not important and we should focus on other topics.

Ignore the timeouts during file playback, note that this will still
report any timeouts that happen in other conditions.

5 seconds of playback should cover most of interesting mpv code, even
for strange samples.

This will likely be reverted at some point in the future, but let first
stabilize the OSS-Fuzz, without dozens of bogus timeouts.
This commit is contained in:
Kacper Michajłow 2024-07-14 00:59:50 +02:00
parent 58f3009b80
commit ed77616f29
4 changed files with 29 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
fuzzers/common.h
View File

@ -43,3 +43,29 @@ static inline bool str_startswith(const char *str, size_t str_len,
return false;
return !memcmp(str, prefix, prefix_len);
}
#ifndef PLAYBACK_TIME_LIMIT
#define PLAYBACK_TIME_LIMIT 5
#endif
static inline void player_loop(mpv_handle *ctx)
{
bool playing = false;
bool loaded = false;
int timeout = -1;
while (1) {
mpv_event *event = mpv_wait_event(ctx, timeout);
if (timeout == PLAYBACK_TIME_LIMIT && event->event_id == MPV_EVENT_NONE)
break;
if (event->event_id == MPV_EVENT_START_FILE)
loaded = playing = true;
if (event->event_id == MPV_EVENT_END_FILE) {
playing = false;
timeout = -1;
}
if (playing && event->event_id == MPV_EVENT_PLAYBACK_RESTART)
timeout = PLAYBACK_TIME_LIMIT;
if (loaded && event->event_id == MPV_EVENT_IDLE)
break;
}
}

9
fuzzers/fuzzer_load.c
View File

@ -81,14 +81,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size)
check_error(mpv_command(ctx, cmd));
#ifdef MPV_LOADFILE
bool loaded = false;
while (1) {
mpv_event *event = mpv_wait_event(ctx, -1);
if (event->event_id == MPV_EVENT_START_FILE)
loaded = true;
if (loaded && event->event_id == MPV_EVENT_IDLE)
break;
}
player_loop(ctx);
#endif
mpv_terminate_destroy(ctx);

9
fuzzers/fuzzer_loadfile_direct.c
View File

@ -75,14 +75,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size)
const char *cmd[] = {"loadfile", data, NULL};
check_error(mpv_command(ctx, cmd));
bool loaded = false;
while (1) {
mpv_event *event = mpv_wait_event(ctx, -1);
if (event->event_id == MPV_EVENT_START_FILE)
loaded = true;
if (loaded && event->event_id == MPV_EVENT_IDLE)
break;
}
player_loop(ctx);
mpv_terminate_destroy(ctx);

9
fuzzers/fuzzer_set_property.c
View File

@ -105,14 +105,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size)
const char *cmd[] = {"loadfile", "av://lavfi:yuvtestsrc=d=0.1", NULL};
check_error(mpv_command(ctx, cmd));
bool loaded = false;
while (1) {
mpv_event *event = mpv_wait_event(ctx, -1);
if (event->event_id == MPV_EVENT_START_FILE)
loaded = true;
if (loaded && event->event_id == MPV_EVENT_IDLE)
break;
}
player_loop(ctx);
#endif
done: