RepoMirrors/mpv
1
0
Fork 0
mirror of https://github.com/mpv-player/mpv synced 2025-01-08 16:10:29 +00:00
Code Issues Releases Wiki Activity

video: un-discourage "vaapi-copy" hwdec mode

Browse Source 
Maybe I don't know what I'm doing. I'm fairly certain though that Intel
does not know what they're doing.
This commit is contained in:
wm4 2015-02-20 22:24:37 +01:00
parent ee653b8a26
commit d71bbcbc98
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
DOCS/man/options.rst
View File

@ -552,7 +552,8 @@ Video
The ``vaapi-copy`` mode allows you to use vaapi with any VO. Because
this copies the decoded video back to system RAM, it's likely less efficient
than the ``vaapi`` mode.
than the ``vaapi`` mode. But there are reports that this is actually faster
as well, and avoids many issues with ``vaapi``.
.. note::

5
video/decode/vaapi.c
View File

@ -69,7 +69,6 @@ struct priv {
int rt_format;
struct mp_image_pool *sw_pool;
bool printed_readback_warning;
};
#define PE(av_codec_id, ff_profile, vdp_profile) \
@ -450,10 +449,6 @@ static struct mp_image *copy_image(struct lavc_ctx *ctx, struct mp_image *img)
struct mp_image *simg = va_surface_download(img, p->sw_pool);
if (simg) {
if (!p->printed_readback_warning) {
MP_WARN(p, "Using GPU readback. This is usually inefficient.\n");
p->printed_readback_warning = true;
}
talloc_free(img);
return simg;
}