From bf6afbc299f300332f36c6aec05ae10479ddc8c9 Mon Sep 17 00:00:00 2001 From: sfan5 Date: Sun, 24 May 2020 22:44:56 +0200 Subject: [PATCH] osdep: remove confstr() fallback for subprocess spawning It doesn't exist on bionic (Android) and accurately emulating execvpe's behaviour isn't all that important. --- osdep/subprocess-posix.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/osdep/subprocess-posix.c b/osdep/subprocess-posix.c index df3c9600ac..e7af4663ea 100644 --- a/osdep/subprocess-posix.c +++ b/osdep/subprocess-posix.c @@ -150,13 +150,8 @@ void mp_subprocess2(struct mp_subprocess_opts *opts, bool killed_by_us = false; int cancel_fd = -1; char *path = getenv("PATH"); - char path_storage[PATH_MAX]; - if (!path) { - path = path_storage; - size_t r = confstr(_CS_PATH, path, sizeof(path_storage)); - if (r == 0 || r >= sizeof(path_storage)) - path[0] = '\0'; // failure, who cares - } + if (!path) + path = ""; // failure, who cares *res = (struct mp_subprocess_result){0};