RepoMirrors
/
mpv
mirror of https://github.com/mpv-player/mpv
1
0
Fork 0
Code Issues Releases Wiki Activity

drm/atomic: disable video plane when unused. 

This patch will make sure that the video plane is hidden when unused.
When using high resolution modes, typically UHD, and embedding mpv,
having the video plane sitting in the back when you don't play any video
is eating a lot of memory bandwidth for compositing.

That patch makes sure that the video layer is just disabled before and
after playback.
This commit is contained in:
LongChair 2018-04-08 09:03:20 +02:00 committed by Jan Ekström
parent 1ccc56eff0
commit ba3d90d9ed
1 changed files with 28 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
video/out/opengl/hwdec_drmprime_drm.c
View File

@ -108,6 +108,30 @@ static void scale_dst_rect(struct ra_hwdec *hw, int source_w, int source_h ,stru
dst->y1 += offset_y; dst->y1 += offset_y;
} }
static void disable_video_plane(struct ra_hwdec *hw)
{
struct priv *p = hw->priv;
if (!p->ctx)
return;
// Disabling video plane is needed on some devices when using the
// primary plane for video. Primary buffer can't be active with no
// framebuffer associated. So we need this function to commit it
// right away as mpv will free all framebuffers on playback end.
drmModeAtomicReqPtr request = drmModeAtomicAlloc();
if (request) {
drm_object_set_property(request, p->ctx->video_plane, "FB_ID", 0);
drm_object_set_property(request, p->ctx->video_plane, "CRTC_ID", 0);
int ret = drmModeAtomicCommit(p->ctx->fd, request,
DRM_MODE_ATOMIC_NONBLOCK, NULL);
if (ret)
MP_ERR(hw, "Failed to commit disable plane request (code %d)", ret);
drmModeAtomicFree(request);
}
}
static int overlay_frame(struct ra_hwdec *hw, struct mp_image *hw_image, static int overlay_frame(struct ra_hwdec *hw, struct mp_image *hw_image,
struct mp_rect *src, struct mp_rect *dst, bool newframe) struct mp_rect *src, struct mp_rect *dst, bool newframe)
{ {
@ -183,6 +207,8 @@ static int overlay_frame(struct ra_hwdec *hw, struct mp_image *hw_image,
} }
} }
} else { } else {
disable_video_plane(hw);
while (p->old_frame.fb.fb_id) while (p->old_frame.fb.fb_id)
set_current_frame(hw, NULL); set_current_frame(hw, NULL);
} }
@ -199,6 +225,7 @@ static void uninit(struct ra_hwdec *hw)
{ {
struct priv *p = hw->priv; struct priv *p = hw->priv;
disable_video_plane(hw);
set_current_frame(hw, NULL); set_current_frame(hw, NULL);
if (p->ctx) { if (p->ctx) {
@ -249,6 +276,7 @@ static int init(struct ra_hwdec *hw)
goto err; goto err;
} }
disable_video_plane(hw);
return 0; return 0;
err: err: