RepoMirrors
/
mpv
mirror of https://github.com/mpv-player/mpv
1
0
Fork 0
Code Issues Releases Wiki Activity

input/keycodes: validate parsed value to avoid overflow

This commit is contained in:
Kacper Michajłow 2024-06-22 03:19:57 +02:00
parent 7fda885747
commit b4123826e5
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
input/keycodes.c
View File

@ -15,6 +15,7 @@
* License along with mpv. If not, see <http://www.gnu.org/licenses/>.
*/
#include <limits.h>
#include <stddef.h>
#include <string.h>
@ -258,8 +259,16 @@ found:
if (code >= 0 && rest.len == 0)
return mp_normalize_keycode(code + modifiers);
if (bstr_startswith0(bname, "0x"))
return mp_normalize_keycode(strtol(name, NULL, 16) + modifiers);
if (bstr_startswith0(bname, "0x")) {
char *end;
long long val = strtoll(name, &end, 16);
if (name == end || val > INT_MAX || val < INT_MIN)
return -1;
long long keycode = val + modifiers;
if (keycode > INT_MAX || keycode < INT_MIN)
return -1;
return mp_normalize_keycode(keycode);
}
for (int i = 0; key_names[i].name != NULL; i++) {
if (strcasecmp(key_names[i].name, name) == 0)