RepoMirrors/mpv
1
0
Fork 0
mirror of https://github.com/mpv-player/mpv synced 2024-12-23 23:32:26 +00:00
Code Issues Releases Wiki Activity

vo_opengl: don't enable PBOs with opengl-hq

Browse Source 
The speed advantages are marginal (at least with the way it's currently
used), and it might actually be slower on some drivers, like Mesa.
This commit is contained in:
wm4 2013-10-23 17:50:49 +02:00
parent 68531e23a1
commit a37c810173
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
DOCS/man/en/vo.rst
View File

@ -320,8 +320,10 @@ Available video output drivers are:
slightly different gamma.
``pbo``
Enable use of PBOs. This is faster, but can sometimes lead to sporadic
and temporary image corruption.
Enable use of PBOs. This is slightly faster, but can sometimes lead to
sporadic and temporary image corruption (in theory, because reupload
is not retried when it fails), and perhaps actually triggers slower
paths with drivers that don't support PBOs properly.
``dither-depth=<N|no|auto>``
Set dither target depth to N. Default: no.
@ -478,7 +480,7 @@ Available video output drivers are:
This is equivalent to::
--vo=opengl:lscale=lanczos2:dither-depth=auto:pbo:fbo-format=rgb16
--vo=opengl:lscale=lanczos2:dither-depth=auto:fbo-format=rgb16
Note that some cheaper LCDs do dithering that gravely interferes with
``opengl``'s dithering. Disabling dithering with ``dither-depth=no`` helps.

2
video/out/vo_opengl.c
View File

@ -383,5 +383,5 @@ const struct vo_driver video_out_opengl_hq = {
.uninit = uninit,
.priv_size = sizeof(struct gl_priv),
.options = options,
.init_option_string = "lscale=lanczos2:dither-depth=auto:pbo:fbo-format=rgb16",
.init_option_string = "lscale=lanczos2:dither-depth=auto:fbo-format=rgb16",
};