RepoMirrors
/
mpv
mirror of https://github.com/mpv-player/mpv
1
0
Fork 0
Code Issues Releases Wiki Activity

vo_rpi: fix DISPMANX_UPDATE_HANDLE_T leak 

Fixes handle leak that happened whenever tvservice callback was invoked.

Powering on the TV causes HDMI unplug and attached events to be sent to
the tvservice callback.

This meant you could only power on/off your TV a finite number of times
before you were unable to allocate additional resources from VideoCore
(usually resulting in a "Could not get DISPMANX objects." error).

Furthermore because the VideoCore kernel driver does not cleanup handles
when a process dies, the only way to recover from the leak was to reboot
the RPI.
This commit is contained in:
Ho Ming Shun 2021-09-06 14:05:12 +08:00 committed by Dudemanguy
parent cc4ada655a
commit 940f871514
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
video/out/vo_rpi.c
View File

@ -804,6 +804,10 @@ static void destroy_dispmanx(struct vo *vo)
disable_renderer(vo);
destroy_overlays(vo);
if (p->update)
vc_dispmanx_update_submit_sync(p->update);
p->update = 0;
if (p->display) {
vc_dispmanx_vsync_callback(p->display, NULL, NULL);
vc_dispmanx_display_close(p->display);
@ -856,9 +860,6 @@ static void uninit(struct vo *vo)
destroy_dispmanx(vo);
if (p->update)
vc_dispmanx_update_submit_sync(p->update);
if (p->renderer)
mmal_component_release(p->renderer);