RepoMirrors/mpv
1
0
Fork 0
mirror of https://github.com/mpv-player/mpv synced 2024-12-18 04:45:33 +00:00
Code Issues Releases Wiki Activity

build: add -Wno-format-zero-length

Browse Source 
This warning makes absolutely no sense. Passing an empty string to
printf-like functions is perfectly fine. In the OSD case, it just sets
an empty message, practically clearing the OSD.
This commit is contained in:
wm4 2014-09-26 13:52:55 +02:00
parent fdf40743bc
commit 8fd954ac8e
4 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
old-configure
View File

@ -380,9 +380,11 @@ addcflags() { cflag_check "$@" && OURCFLAGS="$OURCFLAGS $@" ; }
OURCFLAGS="-std=c99 -Wall $_opt"
addcflags -g -g3 -ggdb
addcflags -Wundef -Wmissing-prototypes -Wshadow -Wno-switch -Wno-parentheses -Wpointer-arith -Wredundant-decls -Wno-pointer-sign -Werror=implicit-function-declaration -Wno-error=deprecated-declarations -Wno-error=unused-function -Wempty-body
addcflags -Wundef -Wmissing-prototypes -Wshadow -Wno-switch -Wno-parentheses -Wpointer-arith -Wredundant-decls -Wno-pointer-sign -Werror=implicit-function-declaration -Wno-error=deprecated-declarations -Wno-error=unused-function
# clang
addcflags -Wno-logical-op-parentheses -fcolor-diagnostics -Wno-tautological-compare -Wno-tautological-constant-out-of-range-compare
# extra
addcflags -Wno-format-zero-length -Wempty-body -Wdisabled-optimization -Wstrict-prototypes
cflag_check -MD -MP && DEPFLAGS="-MD -MP"
cflag_check -lm && _ld_lm="-lm"

2
player/command.c
View File

@ -3698,7 +3698,7 @@ int run_command(MPContext *mpctx, mp_cmd_t *cmd)
if (opts->osd_level > 0) {
set_osd_msg(mpctx, osdl, osd_duration, "OSD level: %d", opts->osd_level);
} else {
set_osd_msg(mpctx, 0, 0, "%s", "");
set_osd_msg(mpctx, 0, 0, "");
}
break;
}

2
player/osd.c
View File

@ -422,7 +422,7 @@ static void add_seek_osd_messages(struct MPContext *mpctx)
if (mpctx->add_osd_seek_info & OSD_SEEK_INFO_TEXT) {
// Never in term-osd mode
if (mpctx->video_out && mpctx->opts->term_osd != 1) {
if (set_osd_msg(mpctx, 1, mpctx->opts->osd_duration, "%s", ""))
if (set_osd_msg(mpctx, 1, mpctx->opts->osd_duration, ""))
mpctx->osd_show_pos = true;
}
}

1
waftools/detections/compiler.py
View File

@ -38,6 +38,7 @@ def __add_gcc_flags__(ctx):
__test_and_add_flags__(ctx, ["-Wempty-body"])
__test_and_add_flags__(ctx, ["-Wdisabled-optimization"])
__test_and_add_flags__(ctx, ["-Wstrict-prototypes"])
__test_and_add_flags__(ctx, ["-Wno-format-zero-length"])
def __add_clang_flags__(ctx):
ctx.env.CFLAGS += ["-Wno-logical-op-parentheses", "-fcolor-diagnostics",