From 74b4c3c531bd454484ed5d04c9aad0bc531ccd4b Mon Sep 17 00:00:00 2001 From: Dudemanguy Date: Tue, 13 Feb 2024 17:35:23 -0600 Subject: [PATCH] player: set hidpi-window-scale to no by default This has defaulted to yes for a very long time, but evidentally it annoys a lot of people (including myself). My argument is that this makes no sense. mpv is for videos; not text. A 1920x1080 video should open as 1920x1080 regardless of whatever the DPI settings of the OS is. This can get very silly when you consider watching a 4k video which will get this additional scale factor which is virtually never desirable. Whether or not the OS and/or WM prevents it from getting larger than the screen depends on a lot of things. Previously some windowing backends required that this option be set to yes in order to report a dpi scale value other than 1, but this should be fixed with the previous commits. The only difference is whether or not to scale the window by the additional factor. Fixes #13465. --- DOCS/interface-changes.rst | 1 + DOCS/man/options.rst | 2 +- options/options.c | 1 - 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/DOCS/interface-changes.rst b/DOCS/interface-changes.rst index 179cc8d762..5bc798bd38 100644 --- a/DOCS/interface-changes.rst +++ b/DOCS/interface-changes.rst @@ -48,6 +48,7 @@ Interface changes - remove `--vo=rpi`, `--gpu-context=rpi`, and `--hwdec=mmal` - add `auto` choice to `--deinterlace` - change `--teletext-page` default from 100 to 0 ("subtitle" in lavc) + - change `--hidpi-window-scale` default to `no` --- mpv 0.37.0 --- - `--save-position-on-quit` and its associated commands now store state files in %LOCALAPPDATA% instead of %APPDATA% directory by default on Windows. diff --git a/DOCS/man/options.rst b/DOCS/man/options.rst index 7325593e3a..32e69af7e5 100644 --- a/DOCS/man/options.rst +++ b/DOCS/man/options.rst @@ -3460,7 +3460,7 @@ Window ``--hidpi-window-scale``, ``--no-hidpi-window-scale`` Scale the window size according to the backing DPI scale factor from the OS - (default: yes). For example, if the OS DPI scaling is set to 200%, mpv's window + (default: no). For example, if the OS DPI scaling is set to 200%, mpv's window size will be multiplied by 2. ``--native-fs``, ``--no-native-fs`` diff --git a/options/options.c b/options/options.c index e6c2ce0e69..7d1babc749 100644 --- a/options/options.c +++ b/options/options.c @@ -237,7 +237,6 @@ const struct m_sub_options vo_sub_opts = { .auto_window_resize = true, .keepaspect = true, .keepaspect_window = true, - .hidpi_window_scale = true, .native_fs = true, .taskbar_progress = true, .border = true,