RepoMirrors
/
mpv
mirror of https://github.com/mpv-player/mpv
1
0
Fork 0
Code Issues Releases Wiki Activity

demux_mkv: read headers at the end of the file sorted by position 

Try to read header elements stored at the end of the file in the order
of their position. (It would be nicer if mkv simply told us a range of
elements to parse, but it doesn't do that.)

This can potentially reduce seek elements, although I didn't check if
any real files trigger this. The real contribution by this change is
that it does not defer reading the CUE index if we need to seek to the
end of the file anyway. This can actually avoid 2 seeks when opening a
file and --start is used, and the file has other headers elements at the
end of the file (like tags).
This commit is contained in:
wm4 2017-05-15 16:40:57 +02:00
parent 5f2c4d4799
commit 6fe75c38d8
1 changed files with 31 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
demux/demux_mkv.c
View File

@ -194,6 +194,7 @@ typedef struct mkv_demuxer {
struct header_elem {
int32_t id;
int64_t pos;
bool needed;
bool parsed;
} *headers;
int num_headers;
@ -1970,6 +1971,7 @@ static int demux_mkv_open(demuxer_t *demuxer, enum demux_check check)
// Read headers that come after the first cluster (i.e. require seeking).
// Note: reading might increase ->num_headers.
// Likewise, ->headers might be reallocated.
int only_cue = -1;
for (int n = 0; n < mkv_d->num_headers; n++) {
struct header_elem *elem = &mkv_d->headers[n];
if (elem->parsed)
@ -1984,14 +1986,36 @@ static int demux_mkv_open(demuxer_t *demuxer, enum demux_check check)
}
continue;
}
if (elem->id == MATROSKA_ID_CUES) {
// Read cues when they are needed, to avoid seeking on opening.
MP_VERBOSE(demuxer, "Deferring reading cues.\n");
continue;
}
if (read_deferred_element(demuxer, elem) < 0)
return -1;
elem->needed = true;
only_cue = only_cue < 0 && elem->id == MATROSKA_ID_CUES;
}
// If there's only 1 needed element, and it's the cues, defer reading.
if (only_cue == 1) {
// Read cues when they are needed, to avoid seeking on opening.
MP_VERBOSE(demuxer, "Deferring reading cues.\n");
} else {
// Read them by ascending position to reduce unneeded seeks.
// O(n^2) because the number of elements is very low.
while (1) {
struct header_elem *lowest = NULL;
for (int n = 0; n < mkv_d->num_headers; n++) {
struct header_elem *elem = &mkv_d->headers[n];
if (!elem->needed)
continue;
if (!lowest || elem->pos < lowest->pos)
lowest = elem;
}
if (!lowest)
break;
lowest->needed = false;
if (read_deferred_element(demuxer, lowest) < 0)
return -1;
}
}
if (!stream_seek(s, start_pos)) {
MP_ERR(demuxer, "Couldn't seek back after reading headers?\n");
return -1;