RepoMirrors/mpv
1
0
Fork 0
mirror of https://github.com/mpv-player/mpv synced 2025-01-31 20:21:49 +00:00
Code Issues Releases Wiki Activity

player/video: check for track and decoder existence

Browse Source 
The track during lavfi-complex can actually be NULL which meant that
ca4192e2df regressed lavfi-complex by
causing mpv to crash during runtime changes of the filter. Additionally,
it's possible for the decoder wrapper to also be NULL. check_framedrop
within write_video checks this, but check_for_hwdec_fallback does not.
Perhaps, it's impossible for this to happen, but we might as well add
the check here to be on the safe side since mp_decoder_wrapper_control
is not designed to handle a NULL.
This commit is contained in:
Dudemanguy 2023-07-25 18:18:32 -05:00 committed by sfan5
parent bc96b23ef6
commit 65840f8889
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
player/video.c
View File

@ -562,7 +562,7 @@ static bool check_for_hwdec_fallback(struct MPContext *mpctx)
{
struct vo_chain *vo_c = mpctx->vo_chain;
if (!vo_c->filter->failed_output_conversion || !vo_c->track)
if (!vo_c->filter->failed_output_conversion || !vo_c->track || !vo_c->track->dec)
return false;
if (mp_decoder_wrapper_control(vo_c->track->dec,
@ -576,9 +576,13 @@ static bool check_for_hwdec_fallback(struct MPContext *mpctx)
static bool check_for_forced_eof(struct MPContext *mpctx)
{
struct vo_chain *vo_c = mpctx->vo_chain;
struct mp_decoder_wrapper *dec = vo_c->track->dec;
if (!vo_c->track || !vo_c->track->dec)
return false;
struct mp_decoder_wrapper *dec = vo_c->track->dec;
bool forced_eof = false;
mp_decoder_wrapper_control(dec, VDCTRL_CHECK_FORCED_EOF, &forced_eof);
return forced_eof;
}