mirror of
https://github.com/mpv-player/mpv
synced 2024-12-29 10:32:15 +00:00
github/workflows: use lua 5.1 on macos
LuaJIT is still actively developed, but upstream is allergic to making new releases for whatever reason. The last tagged release was in May of 2017, so we probably shouldn't expect a new release anytime soon. Now for mpv, this doesn't really matter except in the case of macOS where 2.0.5 is actually a bit broken (and of course the CI uses luajit). More specifically, the 2.0.5 pc is broken and has a "-pagezero_size 10000" flag which causes libmpv to fail (only executables are allowed to use this). This magically works on waf. It's possible that it just happens to ignore the link arguments. However on the meson build, this is broken and led to a really ugly hack using a partial dependency so both mpv and libmpv succeed. Fortunately, the 2.1 luajit branch fixes this. Unfortunately, there's no actual release. Instead, just use Lua 5.1. Note that lua 5.1 is technically deprecated in homebrew, but the chances of this going away is pretty slim since everyone knows that new lua versions are not backwards compatible. Anyways, using 5.1 works fine and lets us get rid of a terrible hack in the meson build. People really shouldn't be using 2.0 LuaJIT anyway.
This commit is contained in:
parent
25bd428393
commit
649556b2b6
2
.github/workflows/build.yml
vendored
2
.github/workflows/build.yml
vendored
@ -79,7 +79,7 @@ jobs:
|
||||
- name: Install dependencies
|
||||
run: |
|
||||
brew update
|
||||
brew install autoconf automake pkg-config libtool python freetype fribidi little-cms2 luajit libass ffmpeg meson
|
||||
brew install autoconf automake pkg-config libtool python freetype fribidi little-cms2 lua@5.1 libass ffmpeg meson
|
||||
|
||||
- name: Build with meson
|
||||
run: |
|
||||
|
Loading…
Reference in New Issue
Block a user