RepoMirrors/mpv
1
0
Fork 0
mirror of https://github.com/mpv-player/mpv synced 2025-01-14 02:51:26 +00:00
Code Issues Releases Wiki Activity

encode: fix occasional init crash due to initialization order issues

Browse Source 
Looks like the recent change to this actually made it crash whenever
audio happened to be initialized first, due to not setting the
mux_stream field before the on_ready callback. Mess a way around this.

Also remove a stray unused variable from ao_lavc.c.
This commit is contained in:
wm4 2020-03-22 21:08:44 +01:00
parent 37f441d61b
commit 6169fba796
2 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
audio/out/ao_lavc.c
View File

@ -232,7 +232,6 @@ static void encode(struct ao *ao, double apts, void **data)
// whatever the fuck this code does?
MP_WARN(ao, "audio frame pts went backwards (%d <- %d), autofixed\n",
(int)frame->pts, (int)ac->lastpts);
int64_t prets = frame->pts;
frame_pts = ac->lastpts + 1;
ac->lastpts = frame_pts;
frame->pts = av_rescale_q(frame_pts, ac->worst_time_base,

15
common/encode_lavc.c
View File

@ -395,10 +395,11 @@ void encode_lavc_stream_eof(struct encode_lavc_context *ctx,
// Signal that you are ready to encode (you provide the codec params etc. too).
// This returns a muxing handle which you can use to add encodec packets.
// Can be called only once per stream. info is copied by callee as needed.
static struct mux_stream *encode_lavc_add_stream(struct encode_lavc_context *ctx,
struct encoder_stream_info *info,
void (*on_ready)(void *ctx),
void *on_ready_ctx)
static void encode_lavc_add_stream(struct encoder_context *enc,
struct encode_lavc_context *ctx,
struct encoder_stream_info *info,
void (*on_ready)(void *ctx),
void *on_ready_ctx)
{
struct encode_priv *p = ctx->priv;
@ -433,13 +434,12 @@ static struct mux_stream *encode_lavc_add_stream(struct encode_lavc_context *ctx
dst->on_ready = on_ready;
dst->on_ready_ctx = on_ready_ctx;
enc->mux_stream = dst;
maybe_init_muxer(ctx);
done:
pthread_mutex_unlock(&ctx->lock);
return dst;
}
// Write a packet. This will take over ownership of `pkt`
@ -922,8 +922,7 @@ bool encoder_init_codec_and_muxer(struct encoder_context *p,
if (avcodec_parameters_from_context(p->info.codecpar, p->encoder) < 0)
goto fail;
p->mux_stream = encode_lavc_add_stream(p->encode_lavc_ctx, &p->info,
on_ready, ctx);
encode_lavc_add_stream(p, p->encode_lavc_ctx, &p->info, on_ready, ctx);
if (!p->mux_stream)
goto fail;