From 5d60ac11b58308fd7d1d828fa9cfd9acd3ea0a96 Mon Sep 17 00:00:00 2001 From: wm4 Date: Sat, 29 Sep 2012 18:40:54 +0200 Subject: [PATCH] vo_opengl: use PBOs by default with opengl-hq It's not really known whether PBO use causes problems of any kind (most likely not). They should slightly increase performance. Use them by default with "opengl-hq". Even though PBOs don't have anything to do with rendering quality, "opengl-hq" provides a test bed for features that should be enabled by default, but aren't out of fear for regressions. --- DOCS/man/en/vo.rst | 2 +- libvo/vo_opengl.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/DOCS/man/en/vo.rst b/DOCS/man/en/vo.rst index 32c6077cb3..fcaa6b0210 100644 --- a/DOCS/man/en/vo.rst +++ b/DOCS/man/en/vo.rst @@ -446,7 +446,7 @@ opengl-hq This is equivalent to: - | --vo=opengl:lscale=lanczos2:fancy-downscaling:dither-depth=0 + | --vo=opengl:lscale=lanczos2:fancy-downscaling:dither-depth=0:pbo Note that some cheaper LCDs do dithering that gravely interferes with vo_opengl's dithering. Disabling dithering with ``dither-depth=-1`` helps. diff --git a/libvo/vo_opengl.c b/libvo/vo_opengl.c index 111f5dcd11..842b9c49f5 100644 --- a/libvo/vo_opengl.c +++ b/libvo/vo_opengl.c @@ -2329,7 +2329,7 @@ static int preinit(struct vo *vo, const char *arg) .vo = vo, .colorspace = MP_CSP_DETAILS_DEFAULTS, .use_npot = 1, - .use_pbo = 0, + .use_pbo = hq, .swap_interval = vo_vsync, .osd_color = 0xffffff, .dither_depth = hq ? 0 : -1,