From 5c2051b1adbfdf476df5e57080ea0ea79abee1a7 Mon Sep 17 00:00:00 2001 From: Dudemanguy Date: Wed, 8 Nov 2023 10:02:49 -0600 Subject: [PATCH] player/command: make show-progress work regardless of osd prefix Having the show-progress command obey no-osd is nonsensical and unintuitive. The show-text command already ignores no-osd, so there's precedence for this. Fixes #5662. --- player/command.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/player/command.c b/player/command.c index 8d6ab07d03..bf4b029b3e 100644 --- a/player/command.c +++ b/player/command.c @@ -5639,6 +5639,10 @@ static void cmd_show_progress(void *p) mpctx->add_osd_seek_info |= (cmd->msg_osd ? OSD_SEEK_INFO_TEXT : 0) | (cmd->bar_osd ? OSD_SEEK_INFO_BAR : 0); + + // If we got neither (i.e. no-osd) force both like osd-auto. + if (!mpctx->add_osd_seek_info) + mpctx->add_osd_seek_info |= OSD_SEEK_INFO_TEXT | OSD_SEEK_INFO_BAR; mpctx->osd_force_update = true; mp_wakeup_core(mpctx); }