mirror of https://github.com/mpv-player/mpv
DOCS/client_api_examples: don't throw char* in C++ code
C++ is the worst language ever, and allows throwing any type, even if it doesn't make sense. In this case, we were throwing char*, which the runtime typically treats as opaque, instead of printing it as message if such an exception was not caught. Conflicts: DOCS/client_api_examples/qml/mpvrenderer.cpp
This commit is contained in:
parent
5c1c8b5fab
commit
58c91c02e2
|
@ -2,6 +2,7 @@
|
|||
|
||||
#include <clocale>
|
||||
#include <sstream>
|
||||
#include <stdexcept>
|
||||
|
||||
#include <QtGlobal>
|
||||
#include <QFileDialog>
|
||||
|
@ -55,7 +56,7 @@ MainWindow::MainWindow(QWidget *parent) :
|
|||
|
||||
mpv = mpv_create();
|
||||
if (!mpv)
|
||||
throw "can't create mpv instance";
|
||||
throw std::runtime_error("can't create mpv instance");
|
||||
|
||||
// Create a video child window. Force Qt to create a native window, and
|
||||
// pass the window ID to the mpv wid option. Works on: X11, win32, Cocoa
|
||||
|
@ -92,7 +93,7 @@ MainWindow::MainWindow(QWidget *parent) :
|
|||
mpv_set_wakeup_callback(mpv, wakeup, this);
|
||||
|
||||
if (mpv_initialize(mpv) < 0)
|
||||
throw "mpv failed to initialize";
|
||||
throw std::runtime_error("mpv failed to initialize");
|
||||
}
|
||||
|
||||
void MainWindow::handle_mpv_event(mpv_event *event)
|
||||
|
|
Loading…
Reference in New Issue