mirror of https://github.com/mpv-player/mpv
client API: disallow masking MPV_EVENT_SHUTDOWN
This makes no sense, because the client is obligated to react to this event. This also happens to fix a deadlock with JSON IPC clients sending "disable_event all", because MPV_EVENT_SHUTDOWN was used to stop the thread driving the socket connection (fixes #2558).
This commit is contained in:
parent
344d44681e
commit
57e691b901
|
@ -711,6 +711,8 @@ int mpv_request_event(mpv_handle *ctx, mpv_event_id event, int enable)
|
|||
{
|
||||
if (!mpv_event_name(event) || enable < 0 || enable > 1)
|
||||
return MPV_ERROR_INVALID_PARAMETER;
|
||||
if (event == MPV_EVENT_SHUTDOWN && !enable)
|
||||
return MPV_ERROR_INVALID_PARAMETER;
|
||||
assert(event < (int)INTERNAL_EVENT_BASE); // excluded above; they have no name
|
||||
pthread_mutex_lock(&ctx->lock);
|
||||
uint64_t bit = 1ULL << event;
|
||||
|
|
Loading…
Reference in New Issue