RepoMirrors
/
mpv
mirror of https://github.com/mpv-player/mpv
1
0
Fork 0
Code Issues Releases Wiki Activity

common/playlist: don't allocate duplicated playlist_path 

If the playlist is loaded directly from a protocol like memory://, the
playlist_path represents the entire playlist. In cases where we have a
large playlist, this results in the entire playlist being duplicated for
each item. For example, if the input size is 300 kB with 10k items, we
end up using 3 GB of memory just to store the playlist_path strings.
This commit is contained in:
Kacper Michajłow 2024-11-16 16:10:00 +01:00
parent 2e31502cb1
commit 51f02679d4
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
common/playlist.c
View File

@ -159,9 +159,10 @@ void playlist_append_file(struct playlist *pl, const char *filename)
void playlist_populate_playlist_path(struct playlist *pl, const char *path)
{
char *playlist_path = talloc_strdup(pl, path);
for (int n = 0; n < pl->num_entries; n++) {
struct playlist_entry *e = pl->entries[n];
e->playlist_path = talloc_strdup(e, path);
e->playlist_path = playlist_path;
}
}
@ -338,6 +339,7 @@ int64_t playlist_transfer_entries_to(struct playlist *pl, int dst_index,
e->id = ++pl->id_alloc;
pl->entries[e->pl_index] = e;
talloc_steal(pl, e);
talloc_steal(pl, e->playlist_path);
}
playlist_update_indexes(pl, dst_index + count, -1);