From 4dcaf70b9653cd04c2159fac6545f25f8e1cbcf9 Mon Sep 17 00:00:00 2001 From: rcombs Date: Sat, 3 Oct 2020 20:09:21 -0500 Subject: [PATCH] Revert "options: disable vsfilter blur compat by default" This reverts commit 3d17e19c2c5ca80f916411e7e61126cac8443baa. The effect of turning off this setting is that mpv doesn't tell libass what the video stream's resolution is. This happens to result in some files having their transforms scaled in ways that give higher performance (as described in #7435) because libass happened to guess a video resolution that resulted in transforms yielding smaller bitmaps, but it's just as easy for the opposite to happen depending on the resolutions and effects involved. The option's name is also somewhat misleading: setting the storage size affects blur, but it also affects stroke (which is far more important for the vast majority of scripts) and 3D transforms (which look very screwy when done wrong). --- DOCS/man/options.rst | 2 +- options/options.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/DOCS/man/options.rst b/DOCS/man/options.rst index 8b437bdfa8..50ff3ec665 100644 --- a/DOCS/man/options.rst +++ b/DOCS/man/options.rst @@ -2379,7 +2379,7 @@ Subtitles ``--sub-ass-vsfilter-blur-compat=`` Scale ``\blur`` tags by video resolution instead of script resolution - (disabled by default). This is bug in VSFilter, which according to some, + (enabled by default). This is bug in VSFilter, which according to some, can't be fixed anymore in the name of compatibility. Note that this uses the actual video resolution for calculating the diff --git a/options/options.c b/options/options.c index c297200a45..a11c1114b9 100644 --- a/options/options.c +++ b/options/options.c @@ -287,7 +287,7 @@ const struct m_sub_options mp_subtitle_sub_opts = { .sub_scale = 1, .ass_vsfilter_aspect_compat = 1, .ass_vsfilter_color_compat = 1, - .ass_vsfilter_blur_compat = 0, + .ass_vsfilter_blur_compat = 1, .ass_style_override = 1, .ass_shaper = 1, .use_embedded_fonts = 1,