mirror of
https://github.com/mpv-player/mpv
synced 2025-01-11 17:39:38 +00:00
getch2.c: fix negative keycodes returned for non-ascii
getch2.c read data into a "char" array, and returned values other than escape sequences directly from there. This meant that it could return negative values (except on platforms where "char" is unsigned) if the input contained bytes >= 128. This would break later parsing in input.c as the values would be interpreted as having the MP_KEY_DOWN flag set, which would make the key binding code think a key is held down (and never released). Fix by changing the buffer type to unsigned char. The bug itself was very old, but started triggering visible breakage more easily after commit 82b8f89baea ("input: rework event reading and command queuing"). Before that the key values would be passed through the input.c "key read function" interface, which (mis)interpreted the negative values as errors from the function, and in most cases discarded them without much visible effect.
This commit is contained in:
parent
377ae044e2
commit
318559056f
@ -65,7 +65,7 @@
|
||||
static struct termios tio_orig;
|
||||
#endif
|
||||
static int getch2_len=0;
|
||||
static char getch2_buf[BUF_LEN];
|
||||
static unsigned char getch2_buf[BUF_LEN];
|
||||
|
||||
int screen_width=80;
|
||||
int screen_height=24;
|
||||
|
Loading…
Reference in New Issue
Block a user