RepoMirrors
/
mpv
mirror of https://github.com/mpv-player/mpv
1
0
Fork 0
Code Issues Releases Wiki Activity

SPARC gcc generates bad code accessing an unaligned and packed structure member 

(See gcc problem report PR c/7847); mplayer crashes with SIGBUS signal.

Added a workaround: copy the unaligned stucture member to a temporary local
variable using memcpy, and use that in the code.


git-svn-id: svn://svn.mplayerhq.hu/mplayer/trunk@7297 b3059339-0415-0410-9bf9-f77b7e298cf2
This commit is contained in:
jkeil 2002-09-06 13:31:33 +00:00
parent 512563bca0
commit 11d695ebbf
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
libmpdemux/open.c
View File

@ -654,8 +654,23 @@ read_next:
if(d->angle_seek){
int i,skip=0;
#if defined(__GNUC__) && defined(__sparc__)
// workaround for a bug in the sparc version of gcc 2.95.X ... 3.2,
// it generates incorrect code for unaligned access to a packed
// structure member, resulting in an mplayer crash with a SIGBUS
// signal.
//
// See also gcc problem report PR c/7847:
// http://gcc.gnu.org/cgi-bin/gnatsweb.pl?database=gcc&cmd=view+audit-trail&pr=7847
for(i=0;i<9;i++){ // check if all values zero:
typeof(d->dsi_pack.sml_agli.data[i].address) tmp_addr;
memcpy(&tmp_addr,&d->dsi_pack.sml_agli.data[i].address,sizeof(tmp_addr));
if((skip=tmp_addr)!=0) break;
}
#else
for(i=0;i<9;i++) // check if all values zero:
if((skip=d->dsi_pack.sml_agli.data[i].address)!=0) break;
#endif
if(skip){
// sml_agli table has valid data (at least one non-zero):
d->cur_pack=d->dsi_pack.dsi_gi.nv_pck_lbn+