From 033af5390f8dc16ef5b318f8feadef971b813be7 Mon Sep 17 00:00:00 2001 From: wm4 Date: Fri, 22 Nov 2019 01:19:00 +0100 Subject: [PATCH] input: make MP_INPUT_RELEASE_ALL a pseudo-key Should be without consequences. I think this is less trouble, because code frequently wants to add/remove bits for modifiers and key state from key codes, and with this change you can't accidentally break it by testing or removing bits from the old -1 value. --- input/input.h | 3 --- input/keycodes.h | 2 ++ 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/input/input.h b/input/input.h index f62a50bdca..bdbfda2dcb 100644 --- a/input/input.h +++ b/input/input.h @@ -23,9 +23,6 @@ #include "cmd.h" -// For mp_input_put_key(): release all keys that are down. -#define MP_INPUT_RELEASE_ALL -1 - struct input_ctx; struct mp_log; diff --git a/input/keycodes.h b/input/keycodes.h index 7385440851..65c31b4d61 100644 --- a/input/keycodes.h +++ b/input/keycodes.h @@ -216,6 +216,8 @@ // No input source should generate this. #define MP_KEY_UNMAPPED (MP_KEY_INTERN+4) #define MP_KEY_ANY_UNICODE (MP_KEY_INTERN+5) +// For mp_input_put_key(): release all keys that are down. +#define MP_INPUT_RELEASE_ALL (MP_KEY_INTERN+6) // Emit a command even on key-up (normally key-up is ignored). This means by // default they binding will be triggered on key-up instead of key-down.