2019-11-08 16:20:57 +00:00
|
|
|
#include "options/path.h"
|
|
|
|
#include "osdep/subprocess.h"
|
test: make tests part of the mpv binary
Until now, each .c file in test/ was built as separate, self-contained
binary. Each binary could be run to execute the tests it contained.
Change this and make them part of the normal mpv binary. Now the tests
have to be invoked via the --unittest option. Do this for two reasons:
- Tests now run within a "properly" initialized mpv instance, so all
services are available.
- Possibly simplifying the situation for future build systems.
The first point is the main motivation. The mpv code is entangled with
mp_log and the option system. It feels like a bad idea to duplicate some
of the initialization of this just so you can call code using them.
I'm also getting rid of cmocka. There wouldn't be any problem to keep it
(it's a perfectly sane set of helpers), but NIH calls. I would have had
to aggregate all tests into a CMUnitTest list, and I don't see how I'd
get different types of entry points easily. Probably easily solvable,
but since we made only pretty basic use of this library, NIH-ing this is
actually easier (I needed a list of tests with custom metadata anyway,
so all what was left was reimplement the assert_* helpers).
Unit tests now don't output anything, and if they fail, they'll simply
crash and leave a message that typically requires inspecting the test
code to figure out what went wrong (and probably editing the test code
to get more information). I even merged the various test functions into
single ones. Sucks, but here you go.
chmap_sel.c is merged into chmap.c, because I didn't see the point of
this being separate. json.c drops the print_message() to go along with
the new silent-by-default idea, also there's a memory leak fix unrelated
to the rest of this commit.
The new code is enabled with --enable-tests (--enable-test goes away).
Due to waf's option parser, --enable-test still works, because it's a
unique prefix to --enable-tests.
2019-11-07 21:42:14 +00:00
|
|
|
#include "player/core.h"
|
2019-11-08 13:35:35 +00:00
|
|
|
#include "tests.h"
|
test: make tests part of the mpv binary
Until now, each .c file in test/ was built as separate, self-contained
binary. Each binary could be run to execute the tests it contained.
Change this and make them part of the normal mpv binary. Now the tests
have to be invoked via the --unittest option. Do this for two reasons:
- Tests now run within a "properly" initialized mpv instance, so all
services are available.
- Possibly simplifying the situation for future build systems.
The first point is the main motivation. The mpv code is entangled with
mp_log and the option system. It feels like a bad idea to duplicate some
of the initialization of this just so you can call code using them.
I'm also getting rid of cmocka. There wouldn't be any problem to keep it
(it's a perfectly sane set of helpers), but NIH calls. I would have had
to aggregate all tests into a CMUnitTest list, and I don't see how I'd
get different types of entry points easily. Probably easily solvable,
but since we made only pretty basic use of this library, NIH-ing this is
actually easier (I needed a list of tests with custom metadata anyway,
so all what was left was reimplement the assert_* helpers).
Unit tests now don't output anything, and if they fail, they'll simply
crash and leave a message that typically requires inspecting the test
code to figure out what went wrong (and probably editing the test code
to get more information). I even merged the various test functions into
single ones. Sucks, but here you go.
chmap_sel.c is merged into chmap.c, because I didn't see the point of
this being separate. json.c drops the print_message() to go along with
the new silent-by-default idea, also there's a memory leak fix unrelated
to the rest of this commit.
The new code is enabled with --enable-tests (--enable-test goes away).
Due to waf's option parser, --enable-test still works, because it's a
unique prefix to --enable-tests.
2019-11-07 21:42:14 +00:00
|
|
|
|
|
|
|
static const struct unittest *unittests[] = {
|
|
|
|
&test_chmap,
|
|
|
|
&test_gl_video,
|
2019-11-08 16:20:57 +00:00
|
|
|
&test_img_format,
|
test: make tests part of the mpv binary
Until now, each .c file in test/ was built as separate, self-contained
binary. Each binary could be run to execute the tests it contained.
Change this and make them part of the normal mpv binary. Now the tests
have to be invoked via the --unittest option. Do this for two reasons:
- Tests now run within a "properly" initialized mpv instance, so all
services are available.
- Possibly simplifying the situation for future build systems.
The first point is the main motivation. The mpv code is entangled with
mp_log and the option system. It feels like a bad idea to duplicate some
of the initialization of this just so you can call code using them.
I'm also getting rid of cmocka. There wouldn't be any problem to keep it
(it's a perfectly sane set of helpers), but NIH calls. I would have had
to aggregate all tests into a CMUnitTest list, and I don't see how I'd
get different types of entry points easily. Probably easily solvable,
but since we made only pretty basic use of this library, NIH-ing this is
actually easier (I needed a list of tests with custom metadata anyway,
so all what was left was reimplement the assert_* helpers).
Unit tests now don't output anything, and if they fail, they'll simply
crash and leave a message that typically requires inspecting the test
code to figure out what went wrong (and probably editing the test code
to get more information). I even merged the various test functions into
single ones. Sucks, but here you go.
chmap_sel.c is merged into chmap.c, because I didn't see the point of
this being separate. json.c drops the print_message() to go along with
the new silent-by-default idea, also there's a memory leak fix unrelated
to the rest of this commit.
The new code is enabled with --enable-tests (--enable-test goes away).
Due to waf's option parser, --enable-test still works, because it's a
unique prefix to --enable-tests.
2019-11-07 21:42:14 +00:00
|
|
|
&test_json,
|
|
|
|
&test_linked_list,
|
2019-11-09 00:50:46 +00:00
|
|
|
&test_repack_sws,
|
|
|
|
#if HAVE_ZIMG
|
|
|
|
&test_repack_zimg,
|
|
|
|
#endif
|
test: make tests part of the mpv binary
Until now, each .c file in test/ was built as separate, self-contained
binary. Each binary could be run to execute the tests it contained.
Change this and make them part of the normal mpv binary. Now the tests
have to be invoked via the --unittest option. Do this for two reasons:
- Tests now run within a "properly" initialized mpv instance, so all
services are available.
- Possibly simplifying the situation for future build systems.
The first point is the main motivation. The mpv code is entangled with
mp_log and the option system. It feels like a bad idea to duplicate some
of the initialization of this just so you can call code using them.
I'm also getting rid of cmocka. There wouldn't be any problem to keep it
(it's a perfectly sane set of helpers), but NIH calls. I would have had
to aggregate all tests into a CMUnitTest list, and I don't see how I'd
get different types of entry points easily. Probably easily solvable,
but since we made only pretty basic use of this library, NIH-ing this is
actually easier (I needed a list of tests with custom metadata anyway,
so all what was left was reimplement the assert_* helpers).
Unit tests now don't output anything, and if they fail, they'll simply
crash and leave a message that typically requires inspecting the test
code to figure out what went wrong (and probably editing the test code
to get more information). I even merged the various test functions into
single ones. Sucks, but here you go.
chmap_sel.c is merged into chmap.c, because I didn't see the point of
this being separate. json.c drops the print_message() to go along with
the new silent-by-default idea, also there's a memory leak fix unrelated
to the rest of this commit.
The new code is enabled with --enable-tests (--enable-test goes away).
Due to waf's option parser, --enable-test still works, because it's a
unique prefix to --enable-tests.
2019-11-07 21:42:14 +00:00
|
|
|
NULL
|
|
|
|
};
|
|
|
|
|
|
|
|
bool run_tests(struct MPContext *mpctx)
|
|
|
|
{
|
|
|
|
char *sel = mpctx->opts->test_mode;
|
|
|
|
assert(sel && sel[0]);
|
|
|
|
|
|
|
|
if (strcmp(sel, "help") == 0) {
|
|
|
|
MP_INFO(mpctx, "Available tests:\n");
|
|
|
|
for (int n = 0; unittests[n]; n++)
|
|
|
|
MP_INFO(mpctx, " %s\n", unittests[n]->name);
|
|
|
|
MP_INFO(mpctx, " all-simple\n");
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2019-11-08 13:21:40 +00:00
|
|
|
struct test_ctx ctx = {
|
|
|
|
.global = mpctx->global,
|
|
|
|
.log = mpctx->log,
|
2019-11-08 16:20:57 +00:00
|
|
|
.ref_path = "test/ref",
|
|
|
|
.out_path = "test/out",
|
2019-11-08 13:21:40 +00:00
|
|
|
};
|
|
|
|
|
2019-11-08 16:20:57 +00:00
|
|
|
if (!mp_path_isdir(ctx.ref_path)) {
|
|
|
|
MP_FATAL(mpctx, "Must be run from git repo root dir.\n");
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
mp_mkdirp(ctx.out_path);
|
|
|
|
assert(mp_path_isdir(ctx.out_path));
|
|
|
|
|
test: make tests part of the mpv binary
Until now, each .c file in test/ was built as separate, self-contained
binary. Each binary could be run to execute the tests it contained.
Change this and make them part of the normal mpv binary. Now the tests
have to be invoked via the --unittest option. Do this for two reasons:
- Tests now run within a "properly" initialized mpv instance, so all
services are available.
- Possibly simplifying the situation for future build systems.
The first point is the main motivation. The mpv code is entangled with
mp_log and the option system. It feels like a bad idea to duplicate some
of the initialization of this just so you can call code using them.
I'm also getting rid of cmocka. There wouldn't be any problem to keep it
(it's a perfectly sane set of helpers), but NIH calls. I would have had
to aggregate all tests into a CMUnitTest list, and I don't see how I'd
get different types of entry points easily. Probably easily solvable,
but since we made only pretty basic use of this library, NIH-ing this is
actually easier (I needed a list of tests with custom metadata anyway,
so all what was left was reimplement the assert_* helpers).
Unit tests now don't output anything, and if they fail, they'll simply
crash and leave a message that typically requires inspecting the test
code to figure out what went wrong (and probably editing the test code
to get more information). I even merged the various test functions into
single ones. Sucks, but here you go.
chmap_sel.c is merged into chmap.c, because I didn't see the point of
this being separate. json.c drops the print_message() to go along with
the new silent-by-default idea, also there's a memory leak fix unrelated
to the rest of this commit.
The new code is enabled with --enable-tests (--enable-test goes away).
Due to waf's option parser, --enable-test still works, because it's a
unique prefix to --enable-tests.
2019-11-07 21:42:14 +00:00
|
|
|
int num_run = 0;
|
|
|
|
|
|
|
|
for (int n = 0; unittests[n]; n++) {
|
|
|
|
const struct unittest *t = unittests[n];
|
|
|
|
|
|
|
|
// Exactly 1 entrypoint please.
|
|
|
|
assert(MP_IS_POWER_OF_2(
|
|
|
|
(t->run ? (1 << 1) : 0)));
|
|
|
|
|
|
|
|
bool run = false;
|
2019-11-08 13:21:40 +00:00
|
|
|
run |= strcmp(sel, "all-simple") == 0 && !t->is_complex;
|
2019-11-08 19:26:57 +00:00
|
|
|
run |= strcmp(sel, t->name) == 0;
|
test: make tests part of the mpv binary
Until now, each .c file in test/ was built as separate, self-contained
binary. Each binary could be run to execute the tests it contained.
Change this and make them part of the normal mpv binary. Now the tests
have to be invoked via the --unittest option. Do this for two reasons:
- Tests now run within a "properly" initialized mpv instance, so all
services are available.
- Possibly simplifying the situation for future build systems.
The first point is the main motivation. The mpv code is entangled with
mp_log and the option system. It feels like a bad idea to duplicate some
of the initialization of this just so you can call code using them.
I'm also getting rid of cmocka. There wouldn't be any problem to keep it
(it's a perfectly sane set of helpers), but NIH calls. I would have had
to aggregate all tests into a CMUnitTest list, and I don't see how I'd
get different types of entry points easily. Probably easily solvable,
but since we made only pretty basic use of this library, NIH-ing this is
actually easier (I needed a list of tests with custom metadata anyway,
so all what was left was reimplement the assert_* helpers).
Unit tests now don't output anything, and if they fail, they'll simply
crash and leave a message that typically requires inspecting the test
code to figure out what went wrong (and probably editing the test code
to get more information). I even merged the various test functions into
single ones. Sucks, but here you go.
chmap_sel.c is merged into chmap.c, because I didn't see the point of
this being separate. json.c drops the print_message() to go along with
the new silent-by-default idea, also there's a memory leak fix unrelated
to the rest of this commit.
The new code is enabled with --enable-tests (--enable-test goes away).
Due to waf's option parser, --enable-test still works, because it's a
unique prefix to --enable-tests.
2019-11-07 21:42:14 +00:00
|
|
|
|
|
|
|
if (run) {
|
|
|
|
if (t->run)
|
2019-11-08 13:21:40 +00:00
|
|
|
t->run(&ctx);
|
test: make tests part of the mpv binary
Until now, each .c file in test/ was built as separate, self-contained
binary. Each binary could be run to execute the tests it contained.
Change this and make them part of the normal mpv binary. Now the tests
have to be invoked via the --unittest option. Do this for two reasons:
- Tests now run within a "properly" initialized mpv instance, so all
services are available.
- Possibly simplifying the situation for future build systems.
The first point is the main motivation. The mpv code is entangled with
mp_log and the option system. It feels like a bad idea to duplicate some
of the initialization of this just so you can call code using them.
I'm also getting rid of cmocka. There wouldn't be any problem to keep it
(it's a perfectly sane set of helpers), but NIH calls. I would have had
to aggregate all tests into a CMUnitTest list, and I don't see how I'd
get different types of entry points easily. Probably easily solvable,
but since we made only pretty basic use of this library, NIH-ing this is
actually easier (I needed a list of tests with custom metadata anyway,
so all what was left was reimplement the assert_* helpers).
Unit tests now don't output anything, and if they fail, they'll simply
crash and leave a message that typically requires inspecting the test
code to figure out what went wrong (and probably editing the test code
to get more information). I even merged the various test functions into
single ones. Sucks, but here you go.
chmap_sel.c is merged into chmap.c, because I didn't see the point of
this being separate. json.c drops the print_message() to go along with
the new silent-by-default idea, also there's a memory leak fix unrelated
to the rest of this commit.
The new code is enabled with --enable-tests (--enable-test goes away).
Due to waf's option parser, --enable-test still works, because it's a
unique prefix to --enable-tests.
2019-11-07 21:42:14 +00:00
|
|
|
num_run++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
MP_INFO(mpctx, "%d unittests successfully run.\n", num_run);
|
|
|
|
|
|
|
|
return num_run > 0; // still error if none
|
|
|
|
}
|
2019-11-08 13:23:56 +00:00
|
|
|
|
|
|
|
#ifdef NDEBUG
|
|
|
|
static_assert(false, "don't define NDEBUG for tests");
|
|
|
|
#endif
|
2019-11-08 13:35:35 +00:00
|
|
|
|
|
|
|
void assert_int_equal_impl(const char *file, int line, int64_t a, int64_t b)
|
|
|
|
{
|
|
|
|
if (a != b) {
|
|
|
|
printf("%s:%d: %"PRId64" != %"PRId64"\n", file, line, a, b);
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void assert_string_equal_impl(const char *file, int line,
|
|
|
|
const char *a, const char *b)
|
|
|
|
{
|
|
|
|
if (strcmp(a, b) != 0) {
|
|
|
|
printf("%s:%d: '%s' != '%s'\n", file, line, a, b);
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void assert_float_equal_impl(const char *file, int line,
|
|
|
|
double a, double b, double tolerance)
|
|
|
|
{
|
|
|
|
if (fabs(a - b) > tolerance) {
|
|
|
|
printf("%s:%d: %f != %f\n", file, line, a, b);
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
}
|
2019-11-08 16:20:57 +00:00
|
|
|
|
|
|
|
FILE *test_open_out(struct test_ctx *ctx, const char *name)
|
|
|
|
{
|
|
|
|
char *path = mp_tprintf(4096, "%s/%s", ctx->out_path, name);
|
|
|
|
FILE *f = fopen(path, "wb");
|
|
|
|
if (!f) {
|
|
|
|
MP_FATAL(ctx, "Could not open '%s' for writing.\n", path);
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
return f;
|
|
|
|
}
|
|
|
|
|
|
|
|
void assert_text_files_equal_impl(const char *file, int line,
|
|
|
|
struct test_ctx *ctx, const char *ref,
|
|
|
|
const char *new, const char *err)
|
|
|
|
{
|
|
|
|
char *path_ref = mp_tprintf(4096, "%s/%s", ctx->ref_path, ref);
|
|
|
|
char *path_new = mp_tprintf(4096, "%s/%s", ctx->out_path, new);
|
|
|
|
|
|
|
|
char *errstr = NULL;
|
|
|
|
int res = mp_subprocess((char*[]){"diff", "-u", "--", path_ref, path_new, 0},
|
|
|
|
NULL, NULL, NULL, NULL, &errstr);
|
|
|
|
|
|
|
|
if (res) {
|
|
|
|
if (res == 1)
|
|
|
|
MP_WARN(ctx, "Note: %s\n", err);
|
|
|
|
MP_FATAL(ctx, "Giving up.\n");
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
}
|