2014-11-22 06:21:33 +00:00
|
|
|
/*
|
|
|
|
* This file is part of mpv.
|
|
|
|
*
|
Relicense some non-MPlayer source files to LGPL 2.1 or later
This covers source files which were added in mplayer2 and mpv times
only, and where all code is covered by LGPL relicensing agreements.
There are probably more files to which this applies, but I'm being
conservative here.
A file named ao_sdl.c exists in MPlayer too, but the mpv one is a
complete rewrite, and was added some time after the original ao_sdl.c
was removed. The same applies to vo_sdl.c, for which the SDL2 API is
radically different in addition (MPlayer supports SDL 1.2 only).
common.c contains only code written by me. But common.h is a strange
case: although it originally was named mp_common.h and exists in MPlayer
too, by now it contains only definitions written by uau and me. The
exceptions are the CONTROL_ defines - thus not changing the license of
common.h yet.
codec_tags.c contained once large tables generated from MPlayer's
codecs.conf, but all of these tables were removed.
From demux_playlist.c I'm removing a code fragment from someone who was
not asked; this probably could be done later (see commit 15dccc37).
misc.c is a bit complicated to reason about (it was split off mplayer.c
and thus contains random functions out of this file), but actually all
functions have been added post-MPlayer. Except get_relative_time(),
which was written by uau, but looks similar to 3 different versions of
something similar in each of the Unix/win32/OSX timer source files. I'm
not sure what that means in regards to copyright, so I've just moved it
into another still-GPL source file for now.
screenshot.c once had some minor parts of MPlayer's vf_screenshot.c, but
they're all gone.
2016-01-19 17:36:06 +00:00
|
|
|
* mpv is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
|
|
* License as published by the Free Software Foundation; either
|
|
|
|
* version 2.1 of the License, or (at your option) any later version.
|
2014-11-22 06:21:33 +00:00
|
|
|
*
|
|
|
|
* mpv is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
Relicense some non-MPlayer source files to LGPL 2.1 or later
This covers source files which were added in mplayer2 and mpv times
only, and where all code is covered by LGPL relicensing agreements.
There are probably more files to which this applies, but I'm being
conservative here.
A file named ao_sdl.c exists in MPlayer too, but the mpv one is a
complete rewrite, and was added some time after the original ao_sdl.c
was removed. The same applies to vo_sdl.c, for which the SDL2 API is
radically different in addition (MPlayer supports SDL 1.2 only).
common.c contains only code written by me. But common.h is a strange
case: although it originally was named mp_common.h and exists in MPlayer
too, by now it contains only definitions written by uau and me. The
exceptions are the CONTROL_ defines - thus not changing the license of
common.h yet.
codec_tags.c contained once large tables generated from MPlayer's
codecs.conf, but all of these tables were removed.
From demux_playlist.c I'm removing a code fragment from someone who was
not asked; this probably could be done later (see commit 15dccc37).
misc.c is a bit complicated to reason about (it was split off mplayer.c
and thus contains random functions out of this file), but actually all
functions have been added post-MPlayer. Except get_relative_time(),
which was written by uau, but looks similar to 3 different versions of
something similar in each of the Unix/win32/OSX timer source files. I'm
not sure what that means in regards to copyright, so I've just moved it
into another still-GPL source file for now.
screenshot.c once had some minor parts of MPlayer's vf_screenshot.c, but
they're all gone.
2016-01-19 17:36:06 +00:00
|
|
|
* GNU Lesser General Public License for more details.
|
2014-11-22 06:21:33 +00:00
|
|
|
*
|
Relicense some non-MPlayer source files to LGPL 2.1 or later
This covers source files which were added in mplayer2 and mpv times
only, and where all code is covered by LGPL relicensing agreements.
There are probably more files to which this applies, but I'm being
conservative here.
A file named ao_sdl.c exists in MPlayer too, but the mpv one is a
complete rewrite, and was added some time after the original ao_sdl.c
was removed. The same applies to vo_sdl.c, for which the SDL2 API is
radically different in addition (MPlayer supports SDL 1.2 only).
common.c contains only code written by me. But common.h is a strange
case: although it originally was named mp_common.h and exists in MPlayer
too, by now it contains only definitions written by uau and me. The
exceptions are the CONTROL_ defines - thus not changing the license of
common.h yet.
codec_tags.c contained once large tables generated from MPlayer's
codecs.conf, but all of these tables were removed.
From demux_playlist.c I'm removing a code fragment from someone who was
not asked; this probably could be done later (see commit 15dccc37).
misc.c is a bit complicated to reason about (it was split off mplayer.c
and thus contains random functions out of this file), but actually all
functions have been added post-MPlayer. Except get_relative_time(),
which was written by uau, but looks similar to 3 different versions of
something similar in each of the Unix/win32/OSX timer source files. I'm
not sure what that means in regards to copyright, so I've just moved it
into another still-GPL source file for now.
screenshot.c once had some minor parts of MPlayer's vf_screenshot.c, but
they're all gone.
2016-01-19 17:36:06 +00:00
|
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
|
|
* License along with mpv. If not, see <http://www.gnu.org/licenses/>.
|
2014-11-22 06:21:33 +00:00
|
|
|
*/
|
|
|
|
|
2017-08-03 20:50:10 +00:00
|
|
|
#include "osdep/posix-spawn.h"
|
2014-11-22 06:21:33 +00:00
|
|
|
#include <poll.h>
|
subprocess: implement proper detached processes on POSIX
The previous method for this sucked: for every launched detached
process, it started a thread, which then would leak if the launched
process didn't end before the player uninitialized. This was very racy
(although I bet the race condition wouldn't trigger in a 100 years), and
wasteful (threads aren't a cheap resource).
Implement it for POSIX directly. posix_spawn() has no direct support for
this, so we need to do it ourselves with fork(). We could probably do it
without fork(), and attempt to collect the PID in another thread. But
then we'd either have a waiting thread again, or we'd need to do an
unsafe waitpid(-1, ...) call. (POSIX process management sucks so badly,
how did they even manage this. Hopefully I'm just missing something, but
I'm not.) So now we depend on both posix_spawn() _and_ fork(), isn't it
fun?
Also call setsid(), to essentially detach the child process from the
terminal. (Otherwise it can receive various signals from the terminal,
which is probably not what you want.) posix_spawn() adds
POSIX_SPAWN_SETSID in newer POSIX releases, but we don't want to rely on
this yet.
The posix_spawnp() call is duplicated, but this is better than somehow
trying to unify the code paths.
Only somewhat tested, so enjoy the bugs.
2020-02-16 20:57:17 +00:00
|
|
|
#include <pthread.h>
|
2014-11-22 06:21:33 +00:00
|
|
|
#include <unistd.h>
|
|
|
|
#include <sys/types.h>
|
|
|
|
#include <sys/wait.h>
|
2015-04-15 20:42:20 +00:00
|
|
|
#include <fcntl.h>
|
2014-11-22 06:21:33 +00:00
|
|
|
#include <errno.h>
|
|
|
|
#include <signal.h>
|
|
|
|
|
2014-11-22 13:38:58 +00:00
|
|
|
#include "osdep/subprocess.h"
|
|
|
|
|
2014-11-22 06:21:33 +00:00
|
|
|
#include "common/common.h"
|
2018-05-17 18:58:49 +00:00
|
|
|
#include "misc/thread_tools.h"
|
|
|
|
#include "osdep/io.h"
|
2014-11-22 13:38:58 +00:00
|
|
|
#include "stream/stream.h"
|
2014-11-22 06:21:33 +00:00
|
|
|
|
|
|
|
extern char **environ;
|
|
|
|
|
2017-06-27 12:22:28 +00:00
|
|
|
#define SAFE_CLOSE(fd) do { if ((fd) >= 0) close((fd)); (fd) = -1; } while (0)
|
|
|
|
|
2020-02-16 20:27:34 +00:00
|
|
|
void mp_subprocess2(struct mp_subprocess_opts *opts,
|
|
|
|
struct mp_subprocess_result *res)
|
2014-11-22 06:21:33 +00:00
|
|
|
{
|
|
|
|
posix_spawn_file_actions_t fa;
|
|
|
|
bool fa_destroy = false;
|
|
|
|
int status = -1;
|
2020-02-16 20:27:34 +00:00
|
|
|
int comm_pipe[MP_SUBPROCESS_MAX_FDS][2];
|
2015-04-15 20:42:20 +00:00
|
|
|
int devnull = -1;
|
subprocess: implement proper detached processes on POSIX
The previous method for this sucked: for every launched detached
process, it started a thread, which then would leak if the launched
process didn't end before the player uninitialized. This was very racy
(although I bet the race condition wouldn't trigger in a 100 years), and
wasteful (threads aren't a cheap resource).
Implement it for POSIX directly. posix_spawn() has no direct support for
this, so we need to do it ourselves with fork(). We could probably do it
without fork(), and attempt to collect the PID in another thread. But
then we'd either have a waiting thread again, or we'd need to do an
unsafe waitpid(-1, ...) call. (POSIX process management sucks so badly,
how did they even manage this. Hopefully I'm just missing something, but
I'm not.) So now we depend on both posix_spawn() _and_ fork(), isn't it
fun?
Also call setsid(), to essentially detach the child process from the
terminal. (Otherwise it can receive various signals from the terminal,
which is probably not what you want.) posix_spawn() adds
POSIX_SPAWN_SETSID in newer POSIX releases, but we don't want to rely on
this yet.
The posix_spawnp() call is duplicated, but this is better than somehow
trying to unify the code paths.
Only somewhat tested, so enjoy the bugs.
2020-02-16 20:57:17 +00:00
|
|
|
pid_t pid = 0;
|
2015-06-27 19:08:55 +00:00
|
|
|
bool spawned = false;
|
|
|
|
bool killed_by_us = false;
|
2020-02-16 20:27:34 +00:00
|
|
|
int cancel_fd = -1;
|
2014-11-22 06:21:33 +00:00
|
|
|
|
2020-02-16 20:27:34 +00:00
|
|
|
*res = (struct mp_subprocess_result){0};
|
|
|
|
|
|
|
|
for (int n = 0; n < opts->num_fds; n++)
|
|
|
|
comm_pipe[n][0] = comm_pipe[n][1] = -1;
|
|
|
|
|
|
|
|
if (opts->cancel) {
|
|
|
|
cancel_fd = mp_cancel_get_fd(opts->cancel);
|
|
|
|
if (cancel_fd < 0)
|
|
|
|
goto done;
|
|
|
|
}
|
|
|
|
|
|
|
|
for (int n = 0; n < opts->num_fds; n++) {
|
|
|
|
if (opts->fds[n].on_read && mp_make_cloexec_pipe(comm_pipe[n]) < 0)
|
|
|
|
goto done;
|
|
|
|
}
|
2014-11-22 06:21:33 +00:00
|
|
|
|
2015-04-15 20:42:20 +00:00
|
|
|
devnull = open("/dev/null", O_RDONLY | O_CLOEXEC);
|
|
|
|
if (devnull < 0)
|
|
|
|
goto done;
|
|
|
|
|
2014-11-22 06:21:33 +00:00
|
|
|
if (posix_spawn_file_actions_init(&fa))
|
|
|
|
goto done;
|
|
|
|
fa_destroy = true;
|
|
|
|
|
2020-02-16 20:27:34 +00:00
|
|
|
// redirect FDs
|
|
|
|
for (int n = 0; n < opts->num_fds; n++) {
|
|
|
|
int src_fd = devnull;
|
|
|
|
if (comm_pipe[n][1] >= 0)
|
|
|
|
src_fd = comm_pipe[n][1];
|
|
|
|
if (opts->fds[n].src_fd >= 0)
|
|
|
|
src_fd = opts->fds[n].src_fd;
|
|
|
|
if (posix_spawn_file_actions_adddup2(&fa, src_fd, opts->fds[n].fd))
|
|
|
|
goto done;
|
|
|
|
}
|
|
|
|
|
|
|
|
char **env = opts->env ? opts->env : environ;
|
subprocess: implement proper detached processes on POSIX
The previous method for this sucked: for every launched detached
process, it started a thread, which then would leak if the launched
process didn't end before the player uninitialized. This was very racy
(although I bet the race condition wouldn't trigger in a 100 years), and
wasteful (threads aren't a cheap resource).
Implement it for POSIX directly. posix_spawn() has no direct support for
this, so we need to do it ourselves with fork(). We could probably do it
without fork(), and attempt to collect the PID in another thread. But
then we'd either have a waiting thread again, or we'd need to do an
unsafe waitpid(-1, ...) call. (POSIX process management sucks so badly,
how did they even manage this. Hopefully I'm just missing something, but
I'm not.) So now we depend on both posix_spawn() _and_ fork(), isn't it
fun?
Also call setsid(), to essentially detach the child process from the
terminal. (Otherwise it can receive various signals from the terminal,
which is probably not what you want.) posix_spawn() adds
POSIX_SPAWN_SETSID in newer POSIX releases, but we don't want to rely on
this yet.
The posix_spawnp() call is duplicated, but this is better than somehow
trying to unify the code paths.
Only somewhat tested, so enjoy the bugs.
2020-02-16 20:57:17 +00:00
|
|
|
|
|
|
|
if (opts->detach) {
|
|
|
|
// If we run it detached, we fork a child to start the process; then
|
|
|
|
// it exits immediately, letting PID 1 inherit it. So we don't need
|
|
|
|
// anything else to collect these child PIDs.
|
|
|
|
sigset_t sigmask, oldmask;
|
|
|
|
sigfillset(&sigmask);
|
|
|
|
pthread_sigmask(SIG_BLOCK, &sigmask, &oldmask);
|
|
|
|
pid_t fres = fork();
|
|
|
|
if (fres < 0)
|
|
|
|
goto done;
|
|
|
|
if (fres == 0) {
|
|
|
|
// child
|
|
|
|
setsid();
|
|
|
|
if (posix_spawnp(&pid, opts->exe, &fa, NULL, opts->args, env))
|
|
|
|
_exit(1);
|
|
|
|
_exit(0);
|
|
|
|
}
|
|
|
|
pthread_sigmask(SIG_SETMASK, &oldmask, NULL);
|
|
|
|
int child_status = 0;
|
|
|
|
while (waitpid(fres, &child_status, 0) < 0 && errno == EINTR) {}
|
|
|
|
if (!WIFEXITED(child_status) || WEXITSTATUS(child_status) != 0)
|
|
|
|
goto done;
|
|
|
|
spawned = true;
|
|
|
|
} else {
|
|
|
|
if (posix_spawnp(&pid, opts->exe, &fa, NULL, opts->args, env))
|
|
|
|
goto done;
|
|
|
|
spawned = true;
|
2014-11-22 06:21:33 +00:00
|
|
|
}
|
|
|
|
|
2020-02-16 20:27:34 +00:00
|
|
|
for (int n = 0; n < opts->num_fds; n++)
|
|
|
|
SAFE_CLOSE(comm_pipe[n][1]);
|
2017-06-27 12:22:28 +00:00
|
|
|
SAFE_CLOSE(devnull);
|
2014-11-22 06:21:33 +00:00
|
|
|
|
2020-02-16 20:27:34 +00:00
|
|
|
while (1) {
|
|
|
|
struct pollfd fds[MP_SUBPROCESS_MAX_FDS + 1];
|
|
|
|
int map_fds[MP_SUBPROCESS_MAX_FDS + 1];
|
|
|
|
int num_fds = 0;
|
|
|
|
for (int n = 0; n < opts->num_fds; n++) {
|
|
|
|
if (comm_pipe[n][0] >= 0) {
|
|
|
|
map_fds[num_fds] = n;
|
|
|
|
fds[num_fds++] = (struct pollfd){
|
|
|
|
.events = POLLIN,
|
|
|
|
.fd = comm_pipe[n][0],
|
|
|
|
};
|
2014-11-22 06:21:33 +00:00
|
|
|
}
|
|
|
|
}
|
2020-02-16 20:27:34 +00:00
|
|
|
if (!num_fds)
|
|
|
|
break;
|
|
|
|
if (cancel_fd >= 0) {
|
|
|
|
map_fds[num_fds] = -1;
|
|
|
|
fds[num_fds++] = (struct pollfd){.events = POLLIN, .fd = cancel_fd};
|
|
|
|
}
|
|
|
|
|
|
|
|
if (poll(fds, num_fds, -1) < 0 && errno != EINTR)
|
2014-11-22 06:21:33 +00:00
|
|
|
break;
|
2020-02-16 20:27:34 +00:00
|
|
|
|
|
|
|
for (int idx = 0; idx < num_fds; idx++) {
|
|
|
|
if (fds[idx].revents) {
|
|
|
|
int n = map_fds[idx];
|
|
|
|
if (n < 0) {
|
|
|
|
// cancel_fd
|
subprocess: implement proper detached processes on POSIX
The previous method for this sucked: for every launched detached
process, it started a thread, which then would leak if the launched
process didn't end before the player uninitialized. This was very racy
(although I bet the race condition wouldn't trigger in a 100 years), and
wasteful (threads aren't a cheap resource).
Implement it for POSIX directly. posix_spawn() has no direct support for
this, so we need to do it ourselves with fork(). We could probably do it
without fork(), and attempt to collect the PID in another thread. But
then we'd either have a waiting thread again, or we'd need to do an
unsafe waitpid(-1, ...) call. (POSIX process management sucks so badly,
how did they even manage this. Hopefully I'm just missing something, but
I'm not.) So now we depend on both posix_spawn() _and_ fork(), isn't it
fun?
Also call setsid(), to essentially detach the child process from the
terminal. (Otherwise it can receive various signals from the terminal,
which is probably not what you want.) posix_spawn() adds
POSIX_SPAWN_SETSID in newer POSIX releases, but we don't want to rely on
this yet.
The posix_spawnp() call is duplicated, but this is better than somehow
trying to unify the code paths.
Only somewhat tested, so enjoy the bugs.
2020-02-16 20:57:17 +00:00
|
|
|
if (pid)
|
|
|
|
kill(pid, SIGKILL);
|
2020-02-16 20:27:34 +00:00
|
|
|
killed_by_us = true;
|
|
|
|
break;
|
|
|
|
} else {
|
|
|
|
char buf[4096];
|
|
|
|
ssize_t r = read(comm_pipe[n][0], buf, sizeof(buf));
|
|
|
|
if (r < 0 && errno == EINTR)
|
|
|
|
continue;
|
|
|
|
if (r > 0 && opts->fds[n].on_read)
|
|
|
|
opts->fds[n].on_read(opts->fds[n].on_read_ctx, buf, r);
|
|
|
|
if (r <= 0)
|
|
|
|
SAFE_CLOSE(comm_pipe[n][0]);
|
|
|
|
}
|
|
|
|
}
|
2014-11-22 06:21:33 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Note: it can happen that a child process closes the pipe, but does not
|
|
|
|
// terminate yet. In this case, we would have to run waitpid() in
|
|
|
|
// a separate thread and use pthread_cancel(), or use other weird
|
2020-02-16 20:27:34 +00:00
|
|
|
// and laborious tricks in order to react to mp_cancel.
|
|
|
|
// So this isn't handled yet.
|
subprocess: implement proper detached processes on POSIX
The previous method for this sucked: for every launched detached
process, it started a thread, which then would leak if the launched
process didn't end before the player uninitialized. This was very racy
(although I bet the race condition wouldn't trigger in a 100 years), and
wasteful (threads aren't a cheap resource).
Implement it for POSIX directly. posix_spawn() has no direct support for
this, so we need to do it ourselves with fork(). We could probably do it
without fork(), and attempt to collect the PID in another thread. But
then we'd either have a waiting thread again, or we'd need to do an
unsafe waitpid(-1, ...) call. (POSIX process management sucks so badly,
how did they even manage this. Hopefully I'm just missing something, but
I'm not.) So now we depend on both posix_spawn() _and_ fork(), isn't it
fun?
Also call setsid(), to essentially detach the child process from the
terminal. (Otherwise it can receive various signals from the terminal,
which is probably not what you want.) posix_spawn() adds
POSIX_SPAWN_SETSID in newer POSIX releases, but we don't want to rely on
this yet.
The posix_spawnp() call is duplicated, but this is better than somehow
trying to unify the code paths.
Only somewhat tested, so enjoy the bugs.
2020-02-16 20:57:17 +00:00
|
|
|
if (pid)
|
|
|
|
while (waitpid(pid, &status, 0) < 0 && errno == EINTR) {}
|
2014-11-22 06:21:33 +00:00
|
|
|
|
|
|
|
done:
|
|
|
|
if (fa_destroy)
|
|
|
|
posix_spawn_file_actions_destroy(&fa);
|
2020-02-16 20:27:34 +00:00
|
|
|
for (int n = 0; n < opts->num_fds; n++) {
|
|
|
|
SAFE_CLOSE(comm_pipe[n][0]);
|
|
|
|
SAFE_CLOSE(comm_pipe[n][1]);
|
|
|
|
}
|
2017-06-27 12:22:28 +00:00
|
|
|
SAFE_CLOSE(devnull);
|
2014-11-22 06:21:33 +00:00
|
|
|
|
subprocess: implement proper detached processes on POSIX
The previous method for this sucked: for every launched detached
process, it started a thread, which then would leak if the launched
process didn't end before the player uninitialized. This was very racy
(although I bet the race condition wouldn't trigger in a 100 years), and
wasteful (threads aren't a cheap resource).
Implement it for POSIX directly. posix_spawn() has no direct support for
this, so we need to do it ourselves with fork(). We could probably do it
without fork(), and attempt to collect the PID in another thread. But
then we'd either have a waiting thread again, or we'd need to do an
unsafe waitpid(-1, ...) call. (POSIX process management sucks so badly,
how did they even manage this. Hopefully I'm just missing something, but
I'm not.) So now we depend on both posix_spawn() _and_ fork(), isn't it
fun?
Also call setsid(), to essentially detach the child process from the
terminal. (Otherwise it can receive various signals from the terminal,
which is probably not what you want.) posix_spawn() adds
POSIX_SPAWN_SETSID in newer POSIX releases, but we don't want to rely on
this yet.
The posix_spawnp() call is duplicated, but this is better than somehow
trying to unify the code paths.
Only somewhat tested, so enjoy the bugs.
2020-02-16 20:57:17 +00:00
|
|
|
if (!spawned || (pid && WIFEXITED(status) && WEXITSTATUS(status) == 127)) {
|
2020-02-16 20:27:34 +00:00
|
|
|
res->error = MP_SUBPROCESS_EINIT;
|
subprocess: implement proper detached processes on POSIX
The previous method for this sucked: for every launched detached
process, it started a thread, which then would leak if the launched
process didn't end before the player uninitialized. This was very racy
(although I bet the race condition wouldn't trigger in a 100 years), and
wasteful (threads aren't a cheap resource).
Implement it for POSIX directly. posix_spawn() has no direct support for
this, so we need to do it ourselves with fork(). We could probably do it
without fork(), and attempt to collect the PID in another thread. But
then we'd either have a waiting thread again, or we'd need to do an
unsafe waitpid(-1, ...) call. (POSIX process management sucks so badly,
how did they even manage this. Hopefully I'm just missing something, but
I'm not.) So now we depend on both posix_spawn() _and_ fork(), isn't it
fun?
Also call setsid(), to essentially detach the child process from the
terminal. (Otherwise it can receive various signals from the terminal,
which is probably not what you want.) posix_spawn() adds
POSIX_SPAWN_SETSID in newer POSIX releases, but we don't want to rely on
this yet.
The posix_spawnp() call is duplicated, but this is better than somehow
trying to unify the code paths.
Only somewhat tested, so enjoy the bugs.
2020-02-16 20:57:17 +00:00
|
|
|
} else if (pid && WIFEXITED(status)) {
|
2020-02-16 20:27:34 +00:00
|
|
|
res->exit_status = WEXITSTATUS(status);
|
subprocess: implement proper detached processes on POSIX
The previous method for this sucked: for every launched detached
process, it started a thread, which then would leak if the launched
process didn't end before the player uninitialized. This was very racy
(although I bet the race condition wouldn't trigger in a 100 years), and
wasteful (threads aren't a cheap resource).
Implement it for POSIX directly. posix_spawn() has no direct support for
this, so we need to do it ourselves with fork(). We could probably do it
without fork(), and attempt to collect the PID in another thread. But
then we'd either have a waiting thread again, or we'd need to do an
unsafe waitpid(-1, ...) call. (POSIX process management sucks so badly,
how did they even manage this. Hopefully I'm just missing something, but
I'm not.) So now we depend on both posix_spawn() _and_ fork(), isn't it
fun?
Also call setsid(), to essentially detach the child process from the
terminal. (Otherwise it can receive various signals from the terminal,
which is probably not what you want.) posix_spawn() adds
POSIX_SPAWN_SETSID in newer POSIX releases, but we don't want to rely on
this yet.
The posix_spawnp() call is duplicated, but this is better than somehow
trying to unify the code paths.
Only somewhat tested, so enjoy the bugs.
2020-02-16 20:57:17 +00:00
|
|
|
} else if (spawned && opts->detach) {
|
|
|
|
// ok
|
2020-02-16 20:27:34 +00:00
|
|
|
} else if (killed_by_us) {
|
|
|
|
res->error = MP_SUBPROCESS_EKILLED_BY_US;
|
2014-11-22 06:21:33 +00:00
|
|
|
} else {
|
2020-02-16 20:27:34 +00:00
|
|
|
res->error = MP_SUBPROCESS_EGENERIC;
|
2014-11-22 06:21:33 +00:00
|
|
|
}
|
|
|
|
}
|