RepoMirrors/mars
1
0
Fork 0
mirror of https://github.com/schoebel/mars synced 2025-04-01 00:06:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

infra: only warn on bad readlink

Browse Source
This commit is contained in:
Thomas Schoebel-Theuer 2020-03-02 14:36:06 +01:00 committed by Thomas Schoebel-Theuer
parent b3fb3d3731
commit 780cb41f1f
1 changed files with 13 additions and 1 deletions

14
kernel/sy_old/sy_generic.c
View File

@ -739,11 +739,23 @@ char *mars_readlink(const char *newpath)
#else
inode = path.dentry->d_inode;
#endif
if (unlikely(!inode || !S_ISLNK(inode->i_mode))) {
if (unlikely(!inode)) {
MARS_ERR("link '%s' has invalid inode\n", newpath);
status = -EINVAL;
goto done_put;
}
if (S_ISDIR(inode->i_mode)) {
/* fail silently: this can happen during
* deletions of directories
*/
status = -EINVAL;
goto done_put;
}
if (!S_ISLNK(inode->i_mode)) {
MARS_WRN("'%s' is no symlink\n", newpath);
status = -EINVAL;
goto done_put;
}
len = i_size_read(inode);
if (unlikely(len <= 0 || len > PAGE_SIZE)) {