RepoMirrors/mars
1
0
Fork 0
mirror of https://github.com/schoebel/mars synced 2025-02-18 04:57:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

logger: avoid writeback starvation by minimum update speed

Browse Source
This commit is contained in:
Thomas Schoebel-Theuer 2019-06-24 15:33:58 +02:00
parent 14d6e84fed
commit 30e3e073a1
3 changed files with 32 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
kernel/mars_trans_logger.c
View File

@ -98,6 +98,8 @@ int trans_logger_mem_usage; // in KB
int trans_logger_pressure_limit = 0;
int trans_logger_writeback_maxage = 900; /* seconds */
int trans_logger_max_interleave = -1;
int trans_logger_resume = 1;
@ -603,6 +605,10 @@ void _inf_callback(struct trans_logger_input *input, bool force)
input->inf.inf_callback(&input->inf);
input->inf_last_jiffies = jiffies;
if (input->inf_min_old != input->inf.inf_min_pos) {
input->inf_min_jiffies = input->inf_last_jiffies;
input->inf_min_old = input->inf.inf_min_pos;
}
} else {
MARS_DBG("%p skipped callback, callback = %p is_operating = %d\n", input, input->inf.inf_callback, input->is_operating);
}
@ -2313,7 +2319,28 @@ struct rank_info global_rank_mref_flying[] = {
static inline
bool _check_pressure(struct trans_logger_brick *brick)
{
int active =
int active;
/*
* Writeback IO starvation can occur when too many concurrents reads
* are filling the IO channnels for a very long time (e.g. when
* full backups are running in parallel to a highly loaded server).
* Ensure a very minimum writeback speed, depending on real time
* (as expected by humans).
*/
if (trans_logger_writeback_maxage) {
struct trans_logger_input *log_input;
long long inf_min_jiffies = 0;
log_input = brick->inputs[brick->log_input_nr];
if (log_input)
inf_min_jiffies = log_input->inf_min_jiffies;
if (!inf_min_jiffies ||
trans_logger_writeback_maxage * HZ + inf_min_jiffies <= (long long)jiffies)
return false;
}
active =
atomic_read(&brick->any_fly_count) +
brick->q_phase[0].q_queued + brick->q_phase[0].q_active;

3
kernel/mars_trans_logger.h
View File

@ -51,6 +51,7 @@ extern int trans_logger_completion_semantics;
extern int trans_logger_do_crc;
extern int trans_logger_mem_usage; // in KB
extern int trans_logger_pressure_limit;
extern int trans_logger_writeback_maxage;
extern int trans_logger_max_interleave;
extern int trans_logger_resume;
extern int trans_logger_replay_timeout; // in s
@ -280,6 +281,8 @@ struct trans_logger_input {
// private
struct log_status logst;
struct list_head pos_list;
long long inf_min_jiffies;
long long inf_min_old;
long long inf_last_jiffies;
struct semaphore inf_mutex;
};

1
kernel/sy_old/mars_proc.c
View File

@ -343,6 +343,7 @@ struct ctl_table mars_table[] = {
INT_ENTRY("mapfree_period_sec", mapfree_period_sec, 0600),
INT_ENTRY("mapfree_grace_keep_mb", mapfree_grace_keep_mb, 0600),
INT_ENTRY("logger_pressure_limit", trans_logger_pressure_limit, 0600),
INT_ENTRY("logger_writeback_maxage_s", trans_logger_writeback_maxage, 0600),
INT_ENTRY("logger_max_interleave", trans_logger_max_interleave, 0600),
INT_ENTRY("logger_resume", trans_logger_resume, 0600),
INT_ENTRY("logger_replay_timeout_sec", trans_logger_replay_timeout, 0600),