all: remove obsolete do_crc

This MUST be always on.

Do not bother with a stone-aged testing option, which never worked.
This commit is contained in:
Thomas Schoebel-Theuer 2022-02-24 06:58:21 +01:00
parent 64ef1c6933
commit 2feb959d71
5 changed files with 1 additions and 13 deletions

View File

@ -413,7 +413,7 @@ bool log_finalize(struct log_status *logst, int len, void (*endio)(void *private
check_flags = 0;
/* Run the CRC on the _original_ data, before compression */
if (logst->do_crc | logst->do_compress) {
{
unsigned char checksum[MARS_DIGEST_SIZE];
check_flags |=

View File

@ -147,7 +147,6 @@ struct log_status {
int chunk_size; // must be at least 8K (better 64k)
int max_size; // max payload length
int io_prio;
bool do_crc;
bool do_compress;
// informational
atomic_t mref_flying;

View File

@ -90,13 +90,6 @@ int trans_logger_completion_semantics = 1;
/* Global enabling / disabling of features */
int trans_logger_do_crc =
#ifdef CONFIG_MARS_DEBUG
true;
#else
false;
#endif
int trans_logger_allow_compress = true;
int trans_logger_mem_usage; // in KB
@ -1664,7 +1657,6 @@ bool phase0_startio(struct trans_logger_mref_aspect *orig_mref_a)
input = orig_mref_a->log_input;
CHECK_PTR(input, err);
logst = &input->logst;
logst->do_crc = trans_logger_do_crc;
logst->do_compress =
trans_logger_allow_compress &&
(usable_compression_mask & MREF_COMPRESS_ANY);
@ -2009,7 +2001,6 @@ bool _phase2_startio(struct trans_logger_mref_aspect *sub_mref_a)
input = sub_mref_a->log_input;
CHECK_PTR(input, err);
logst = &input->logst;
logst->do_crc = trans_logger_do_crc;
{
struct log_header l = {

View File

@ -48,7 +48,6 @@
* 2 = late completion
*/
extern int trans_logger_completion_semantics;
extern int trans_logger_do_crc;
extern int trans_logger_allow_compress;
extern int trans_logger_mem_usage; // in KB
extern int trans_logger_pressure_limit;

View File

@ -448,7 +448,6 @@ struct ctl_table mars_table[] = {
LIMITER_ENTRIES(&bio_throttle_write, "debug_bio_throttle_write", "kb"),
#endif
INT_ENTRY("logger_completion_semantics", trans_logger_completion_semantics, 0600),
INT_ENTRY("logger_do_crc", trans_logger_do_crc, 0600),
INT_ENTRY("logger_allow_compress", trans_logger_allow_compress, 0600),
INT_ENTRY("zlib_compress_level", mars_zlib_compression_level, 0600),
INT_ENTRY("syslog_min_class", brick_say_syslog_min, 0600),