RepoMirrors
/
linux-firmware
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

copy-firmware.sh: reset and consistently handle destdir 

Currently we don't reset/override the destdir variable, so we end up inheriting
whatever the caller's environment has for it. While it may work, it's not
particularly consistent (be that within the script or other tools) nor is it
obvious.

While in here, ensure we handle the variable with test -z/-n instead of varying
other constructs.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
This commit is contained in:
Emil Velikov 2024-09-23 12:09:08 +01:00 committed by Mario Limonciello
parent e8f8537768
commit a3446bc1a7
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
copy-firmware.sh
View File

@ -9,6 +9,7 @@ prune=no
# shellcheck disable=SC2209 # shellcheck disable=SC2209
compress=cat compress=cat
compext= compext=
destdir=
while test $# -gt 0; do while test $# -gt 0; do
case $1 in case $1 in
@ -45,7 +46,7 @@ while test $# -gt 0; do
;; ;;
*) *)
if test "x$destdir" != "x"; then if test -n "$destdir"; then
echo "ERROR: unknown command-line options: $*" echo "ERROR: unknown command-line options: $*"
exit 1 exit 1
fi fi
@ -56,7 +57,7 @@ while test $# -gt 0; do
esac esac
done done
if [ -z "$destdir" ]; then if test -z "$destdir"; then
echo "ERROR: destination directory was not specified" echo "ERROR: destination directory was not specified"
exit 1 exit 1
fi fi