From 67bf50e72c3ea3a0bbc6327542d56996ad645b75 Mon Sep 17 00:00:00 2001 From: Emil Velikov Date: Mon, 5 Jun 2023 14:58:10 +0100 Subject: [PATCH] copy-firmware: drop obsolete backticks, quote As mentioned by shellcheck backticks are considered legacy. Plus we should ensure the output is quoted, otherwise we'll get word splitting. Signed-off-by: Emil Velikov Signed-off-by: Josh Boyer --- copy-firmware.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/copy-firmware.sh b/copy-firmware.sh index efbc3cb6..31e372ab 100755 --- a/copy-firmware.sh +++ b/copy-firmware.sh @@ -46,7 +46,7 @@ grep -E '^Link:' WHENCE | sed -e 's/^Link: *//g;s/-> //g' | while read f d; do cp -d "$f" "$destdir/$f" if test "x$d" != "x"; then - target=`readlink "$f"` + target="$(readlink "$f")" if test "x$target" != "x$d"; then $verbose "WARNING: inconsistent symlink target: $target != $d"