RepoMirrors
/
linux-firmware
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Makefile: error out of 'install' if COPYOPTS is set 

Since https://gitlab.com/kernel-firmware/linux-firmware/-/merge_requests/319
and https://gitlab.com/kernel-firmware/linux-firmware/-/merge_requests/331 ,
doing `make COPYOPTS="blahblah" install` does not fail, but does
not do what it did before. This is a surprising and possibly
undesired result (in Fedora, it led to our firmware suddenly
taking up 500MB more space on disk, and that led to a bunch of
live image builds failing).

To make the change more apparent, let's just fail out with an
explanatory message if invoked with COPYOPTS set.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
Co-authored by: Emil Velikov <emil.l.velikov@gmail.com>
This commit is contained in:
Adam Williamson 2024-10-19 13:57:38 -07:00
parent 41a6688a08
commit 4f397306dc
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Makefile
View File

@ -30,6 +30,11 @@ dedup:
./dedup-firmware.sh $(DESTDIR)$(FIRMWAREDIR)
install:
@if [ -n "${COPYOPTS}" ]; then \
echo "COPYOPTS is not used since linux-firmware-20241017!"; \
echo "You may want to use install{-xz,-zst} and dedup targets instead"; \
false; \
fi
install -d $(DESTDIR)$(FIRMWAREDIR)
./copy-firmware.sh $(DESTDIR)$(FIRMWAREDIR)
@echo "Now run \"make dedup\" to de-duplicate any firmware files"