mirror of
git://sourceware.org/git/libabigail.git
synced 2025-02-13 03:57:33 +00:00
09de4435ce
It appears that two different types from two different translation units might have the same name in a DSO, like in the example of this bug. This violates the One Definition Rule, which we rely on to go fast, and more importantly, it introduces type canonicalization errors. This patch recognizes more of these ODR violation cases by looking at the size of the types. That is, if two types (from the same DSO) with the same name have different sizes, then they are different. * src/abg-ir.cc (type_base::get_canonical_type_for): Look at the size of types with the same name which could be considered ODR-equal, to spot possible violations that would induce a type canonicalization error. * tests/data/test-read-dwarf/test21-pr19092.so: New test input binary. * tests/data/test-read-dwarf/test21-pr19092.so.abi: New reference abixml for the binary above. * tests/data/Makefile.am: Add the new test input above to source distribution. * tests/data/test-read-dwarf/test9-pr18818-clang.so.abi: Adjust. * tests/data/test-read-dwarf/test12-pr18844.so.abi: Likewise. * tests/data/test-read-dwarf/test20-pr19025-libvtkParallelCore-6.1.so.abi: Likewise. * tests/test-read-dwarf.cc (int_out_specs): Add the two test input above. Signed-off-by: Dodji Seketeli <dodji@redhat.com> |
||
|---|---|---|
| .. | ||
| test0 | ||
| test0.abi | ||
| test0.cc | ||
| test1 | ||
| test1.abi | ||
| test1.cc | ||
| test2-0.cc | ||
| test2-1.cc | ||
| test2.h | ||
| test2.so | ||
| test2.so.abi | ||
| test3.c | ||
| test3.so | ||
| test3.so.abi | ||
| test4.c | ||
| test4.so | ||
| test4.so.abi | ||
| test5.cc | ||
| test5.o | ||
| test5.o.abi | ||
| test6.cc | ||
| test6.so | ||
| test6.so.abi | ||
| test7.cc | ||
| test7.so | ||
| test7.so.abi | ||
| test8-qualified-this-pointer.cc | ||
| test8-qualified-this-pointer.so | ||
| test8-qualified-this-pointer.so.abi | ||
| test9-pr18818-clang.so | ||
| test9-pr18818-clang.so.abi | ||
| test10-pr18818-gcc.so | ||
| test10-pr18818-gcc.so.abi | ||
| test11-pr18828.so | ||
| test11-pr18828.so.abi | ||
| test12-pr18844.so | ||
| test12-pr18844.so.abi | ||
| test13-pr18894.so | ||
| test13-pr18894.so.abi | ||
| test14-pr18893.so | ||
| test14-pr18893.so.abi | ||
| test15-pr18892.so | ||
| test15-pr18892.so.abi | ||
| test16-pr18904.so | ||
| test16-pr18904.so.abi | ||
| test17-pr19027.so | ||
| test17-pr19027.so.abi | ||
| test18-pr19037-libvtkRenderingLIC-6.1.so | ||
| test18-pr19037-libvtkRenderingLIC-6.1.so.abi | ||
| test19-pr19023-libtcmalloc_and_profiler.so | ||
| test19-pr19023-libtcmalloc_and_profiler.so.abi | ||
| test20-pr19025-libvtkParallelCore-6.1.so | ||
| test20-pr19025-libvtkParallelCore-6.1.so.abi | ||
| test21-pr19092.so | ||
| test21-pr19092.so.abi | ||