mirror of
git://sourceware.org/git/libabigail.git
synced 2024-12-16 23:14:36 +00:00
578ba12139
Control-Flow-Integrity (CFI) when enabled in clang built binaries introduces an indirection when looking up ELF symbols. For DSO, the symbol table (.dynsym) will still contain the symbols, but additional symbols with suffix .cfi will be added to the full .symtab. Unfortunately, the DWARF debug information refers to CFI symbols by address to the .cfi suffixed variants as they point to the actual implementation. When the dwarf reader is determining whether to suppress variable or function declarations, it does so by identifying if there is an associated ELF symbol at the given address read from DWARF. Unless we know about the alternative address, this will fail and the type information will be suppressed. Hence add the .cfi symbol values to the lookup map to associate their address with the corresponding publicly exported symbol. * src/abg-symtab-reader.cc (symtab::load_): use new add_alternative_address_lookups method. (add_alternative_address_lookups): New method. * src/abg-symtab-reader.h (add_alternative_address_lookups): new function declaration. * tests/data/test-read-dwarf/test-libaaudio.so: New test data. * tests/data/test-read-dwarf/test-libaaudio.so.abi: New test data. * tests/data/Makefile.am: Add the two new tests input to source distribution. * tests/test-read-dwarf.cc: New test case. Reported-by: Dan Albert <danalbert@google.com> Reviewed-by: Giuliano Procida <gprocida@google.com> Signed-off-by: Matthias Maennich <maennich@google.com> Signed-off-by: Dodji Seketeli <dodji@redhat.com> |
||
|---|---|---|
| .. | ||
| data | ||
| lib | ||
| .gitignore | ||
| Makefile.am | ||
| mockfedabipkgdiff.in | ||
| print-diff-tree.cc | ||
| runtestcanonicalizetypes.sh.in | ||
| runtestdefaultsupprs.py.in | ||
| runtestdefaultsupprspy3.sh.in | ||
| runtestfedabipkgdiff.py.in | ||
| runtestfedabipkgdiffpy3.sh.in | ||
| runtestslowselfcompare.sh.in | ||
| test-abicompat.cc | ||
| test-abidiff-exit.cc | ||
| test-abidiff.cc | ||
| test-alt-dwarf-file.cc | ||
| test-annotate.cc | ||
| test-core-diff.cc | ||
| test-cxx-compat.cc | ||
| test-diff2.cc | ||
| test-diff-dwarf-abixml.cc | ||
| test-diff-dwarf.cc | ||
| test-diff-filter.cc | ||
| test-diff-pkg.cc | ||
| test-diff-suppr.cc | ||
| test-dot.cc | ||
| test-elf-helpers.cc | ||
| test-ini.cc | ||
| test-ir-walker.cc | ||
| test-kmi-whitelist.cc | ||
| test-lookup-syms.cc | ||
| test-read-dwarf.cc | ||
| test-read-write.cc | ||
| test-svg.cc | ||
| test-symtab-reader.cc | ||
| test-symtab.cc | ||
| test-tools-utils.cc | ||
| test-types-stability.cc | ||
| test-utils.cc | ||
| test-utils.h | ||
| test-valgrind-suppressions.supp | ||
| update-test-output.py | ||