mirror of
git://sourceware.org/git/libabigail.git
synced 2024-12-25 11:12:14 +00:00
fc55e7f343
As per https://sourceware.org/bugzilla/show_bug.cgi?id=18146, abidiff the exit code of abidiff and abicompat is now a bit field that can be inspected to know if the ABI change reported is incompatible for sure, or if it needs user review of the output to decide. This patch also updates the documentation. * doc/manuals/abicompat.rst: Update documentation for abicompat exit codes. * doc/manuals/abidiff.rst: Likewise for abidiff exit codes. * include/abg-tools-utils.h (enum abidiff_status): Declare new enum. (operator{|,&,|=}): Declare new operators for the new enum abidiff_status. (abidiff_status_has_error, abidiff_status_has_abi_change) (abidiff_status_has_incompatible_abi_change): Declare new functions. * src/abg-tools-utils.cc (operator{|,&,|=}): Define these new operators. (abidiff_status_has_error, abidiff_status_has_abi_change) (abidiff_status_has_incompatible_abi_change): Define new functions. * tests/test-diff-filter.cc (main): Adjust for the new exit code of abidiff. * tests/test-diff-suppr.cc (main): Likewise. * tests/test-abicompat.cc (main): Likewise. * tools/abicompat.cc (enum abicompat_status): Remove. (operator{|,&,|=}): Remove these operators for enum abicompat_status. (perform_compat_check_in_normal_mode) (perform_compat_check_in_weak_mode): Return abidiff_status instead of abicompat_status. Adjust therefore. (main): Adjust to return abidiff_status now, instead of a just zero for all non-error cases. * tools/abidiff.cc (main): Likewise. Signed-off-by: Dodji Seketeli <dodji@redhat.com>
199 lines
6.4 KiB
C++
199 lines
6.4 KiB
C++
// -*- Mode: C++ -*-
|
|
//
|
|
// Copyright (C) 2014-2015 Red Hat, Inc.
|
|
//
|
|
// This file is part of the GNU Application Binary Interface Generic
|
|
// Analysis and Instrumentation Library (libabigail). This library is
|
|
// free software; you can redistribute it and/or modify it under the
|
|
// terms of the GNU Lesser General Public License as published by the
|
|
// Free Software Foundation; either version 3, or (at your option) any
|
|
// later version.
|
|
|
|
// This library is distributed in the hope that it will be useful, but
|
|
// WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
// General Lesser Public License for more details.
|
|
|
|
// You should have received a copy of the GNU Lesser General Public
|
|
// License along with this program; see the file COPYING-LGPLV3. If
|
|
// not, see <http://www.gnu.org/licenses/>.
|
|
|
|
// Author: Dodji Seketeli
|
|
|
|
/// @file
|
|
///
|
|
/// Given a program P that links against a library L of version V
|
|
/// denoted L(V), this program checks if P is still ABI compatible
|
|
/// with a subsequent version of L denoted L(V+N), N being a positive
|
|
/// integer. The result of the check is a report that is compared
|
|
/// against a reference report. This program actually performs these
|
|
/// checks for a variety of tuple {P, L(V), L(V+N)}
|
|
///
|
|
/// The set of input files and reference reports to consider should be
|
|
/// present in the source distribution.
|
|
|
|
#include <cstring>
|
|
#include <string>
|
|
#include <fstream>
|
|
#include <iostream>
|
|
#include <cstdlib>
|
|
#include "abg-tools-utils.h"
|
|
#include "test-utils.h"
|
|
|
|
using std::string;
|
|
using std::cerr;
|
|
|
|
struct InOutSpec
|
|
{
|
|
const char* in_app_path;
|
|
const char* in_lib1_path;
|
|
const char* in_lib2_path;
|
|
const char* suppressions;
|
|
const char* options;
|
|
const char* in_report_path;
|
|
const char* out_report_path;
|
|
};
|
|
|
|
InOutSpec in_out_specs[] =
|
|
{
|
|
{
|
|
"data/test-abicompat/test0-fn-changed-app",
|
|
"data/test-abicompat/libtest0-fn-changed-libapp-v0.so",
|
|
"data/test-abicompat/libtest0-fn-changed-libapp-v1.so",
|
|
"",
|
|
"--show-base-names --no-redundant",
|
|
"data/test-abicompat/test0-fn-changed-report-0.txt",
|
|
"output/test-abicompat/test0-fn-changed-report-0.txt",
|
|
},
|
|
{
|
|
"data/test-abicompat/test0-fn-changed-app",
|
|
"data/test-abicompat/libtest0-fn-changed-libapp-v0.so",
|
|
"data/test-abicompat/libtest0-fn-changed-libapp-v1.so",
|
|
"data/test-abicompat/test0-fn-changed-0.suppr",
|
|
"--show-base-names --no-redundant",
|
|
"data/test-abicompat/test0-fn-changed-report-1.txt",
|
|
"output/test-abicompat/test0-fn-changed-report-1.txt",
|
|
},
|
|
{
|
|
"data/test-abicompat/test1-fn-removed-app",
|
|
"data/test-abicompat/libtest1-fn-removed-v0.so",
|
|
"data/test-abicompat/libtest1-fn-removed-v1.so",
|
|
"",
|
|
"--show-base-names --no-redundant",
|
|
"data/test-abicompat/test1-fn-removed-report-0.txt",
|
|
"output/test-abicompat/test1-fn-removed-report-0.txt",
|
|
},
|
|
{
|
|
"data/test-abicompat/test2-var-removed-app",
|
|
"data/test-abicompat/libtest2-var-removed-v0.so",
|
|
"data/test-abicompat/libtest2-var-removed-v1.so",
|
|
"",
|
|
"--show-base-names --no-redundant",
|
|
"data/test-abicompat/test2-var-removed-report-0.txt",
|
|
"output/test-abicompat/test2-var-removed-report-0.txt",
|
|
},
|
|
{
|
|
"data/test-abicompat/test3-fn-removed-app",
|
|
"data/test-abicompat/libtest3-fn-removed-v0.so",
|
|
"data/test-abicompat/libtest3-fn-removed-v1.so",
|
|
"",
|
|
"--show-base-names --no-redundant",
|
|
"data/test-abicompat/test3-fn-removed-report-0.txt",
|
|
"output/test-abicompat/test3-fn-removed-report-0.txt",
|
|
},
|
|
{
|
|
"data/test-abicompat/test4-soname-changed-app",
|
|
"data/test-abicompat/libtest4-soname-changed-v0.so",
|
|
"data/test-abicompat/libtest4-soname-changed-v1.so",
|
|
"",
|
|
"--show-base-names --no-redundant",
|
|
"data/test-abicompat/test4-soname-changed-report-0.txt",
|
|
"output/test-abicompat/test4-soname-changed-report-0.txt",
|
|
},
|
|
{
|
|
"data/test-abicompat/test5-fn-changed-app",
|
|
"data/test-abicompat/libtest5-fn-changed-libapp-v1.so",
|
|
"",
|
|
"",
|
|
"--show-base-names --weak-mode",
|
|
"data/test-abicompat/test5-fn-changed-report-0.txt",
|
|
"output/test-abicompat/test5-fn-changed-report-0.txt",
|
|
},
|
|
{
|
|
"data/test-abicompat/test6-var-changed-app",
|
|
"data/test-abicompat/libtest6-var-changed-libapp-v1.so",
|
|
"",
|
|
"",
|
|
"--show-base-names --weak-mode",
|
|
"data/test-abicompat/test6-var-changed-report-0.txt",
|
|
"output/test-abicompat/test6-var-changed-report-0.txt",
|
|
},
|
|
// This entry must be the last one.
|
|
{0, 0, 0, 0, 0, 0, 0}
|
|
};
|
|
|
|
int
|
|
main()
|
|
{
|
|
using abigail::tests::get_src_dir;
|
|
using abigail::tests::get_build_dir;
|
|
using abigail::tools_utils::ensure_parent_dir_created;
|
|
using abigail::tools_utils::abidiff_status;
|
|
|
|
bool is_ok = true;
|
|
string in_app_path, in_lib1_path, in_lib2_path, suppression_path,
|
|
abicompat_options, ref_report_path, out_report_path, abicompat, cmd;
|
|
|
|
for (InOutSpec* s = in_out_specs; s->in_app_path; ++s)
|
|
{
|
|
in_app_path = get_src_dir() + "/tests/" + s->in_app_path;
|
|
in_lib1_path = get_src_dir() + "/tests/" + s->in_lib1_path;
|
|
if (s->in_lib2_path && strcmp(s->in_lib2_path, ""))
|
|
in_lib2_path = get_src_dir() + "/tests/" + s->in_lib2_path;
|
|
else
|
|
in_lib2_path.clear();
|
|
if (s->suppressions == 0 || !strcmp(s->suppressions, ""))
|
|
suppression_path.clear();
|
|
else
|
|
suppression_path = get_src_dir() + "/tests/" + s->suppressions;
|
|
abicompat_options = s->options;
|
|
ref_report_path = get_src_dir() + "/tests/" + s->in_report_path;
|
|
out_report_path = get_build_dir() + "/tests/" + s->out_report_path;
|
|
|
|
if (!ensure_parent_dir_created(out_report_path))
|
|
{
|
|
cerr << "could not create parent directory for "
|
|
<< out_report_path;
|
|
is_ok = false;
|
|
continue;
|
|
}
|
|
|
|
abicompat = get_build_dir() + "/tools/abicompat";
|
|
if (!suppression_path.empty())
|
|
abicompat += " --suppressions " + suppression_path;
|
|
abicompat += " " + abicompat_options;
|
|
|
|
cmd = abicompat + " " + in_app_path + " " + in_lib1_path;
|
|
if (!in_lib2_path.empty())
|
|
cmd += string(" ") + in_lib2_path;
|
|
|
|
cmd += " > " + out_report_path;
|
|
|
|
bool abicompat_ok = true;
|
|
abidiff_status status = static_cast<abidiff_status>(system(cmd.c_str()));
|
|
if (abigail::tools_utils::abidiff_status_has_error(status))
|
|
abicompat_ok = false;
|
|
|
|
if (abicompat_ok)
|
|
{
|
|
cmd = "diff -u " + ref_report_path + " " + out_report_path;
|
|
if (system(cmd.c_str()))
|
|
is_ok = false;
|
|
}
|
|
else
|
|
is_ok = false;
|
|
}
|
|
|
|
return !is_ok;
|
|
}
|