mirror of
git://sourceware.org/git/libabigail.git
synced 2024-12-23 18:22:08 +00:00
c0a31b48c7
While working on something else, I noticed that the abilint tool would crash when trying to write information relative to some symbol information. It turned out that invoking corpus::get_fun_symbol_map() or corpus::get_var_symbol_map() on a corpus that has an empty function (or variable) symbol map yields a crash. This patch fixes that. To test the fix I had to extend the test-read-write.cc test harness to teach it to load corpus files too; up to now it was only loading simple translation unit files (named Binary Instrumentation files). I then created a native xml corpus file using the abidw tool on a simple shared library I created. That corpus file does have an empty variable symbol section which triggers the crash on a non-fixed tree. * src/abg-corpus.cc (corpus::{get_fun_symbol_map_sptr, get_var_symbol_map_sptr}): Make sure the symbol map is always constructed, even if it's empty. * tests/data/test-read-write/test26.xml: New test input data. * tests/test-read-write.cc (in_out_spec): Add this new test input data to the list of input data to run the harness on. (main): Support reading and writing corpus files alongside translation unit files that we were handling already. * tests/data/Makefile.am: Add the new test input data to source distribution. Signed-off-by: Dodji Seketeli <dodji@redhat.com>
242 lines
6.0 KiB
C++
242 lines
6.0 KiB
C++
// -*- Mode: C++ -*-
|
|
//
|
|
// Copyright (C) 2013-2014 Red Hat, Inc.
|
|
//
|
|
// This file is part of the GNU Application Binary Interface Generic
|
|
// Analysis and Instrumentation Library (libabigail). This library is
|
|
// free software; you can redistribute it and/or modify it under the
|
|
// terms of the GNU Lesser General Public License as published by the
|
|
// Free Software Foundation; either version 3, or (at your option) any
|
|
// later version.
|
|
|
|
// This library is distributed in the hope that it will be useful, but
|
|
// WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
// General Lesser Public License for more details.
|
|
|
|
// You should have received a copy of the GNU Lesser General Public
|
|
// License along with this program; see the file COPYING-LGPLV3. If
|
|
// not, see <http://www.gnu.org/licenses/>.
|
|
|
|
/// @file read an XML corpus file (in the native Abigail XML format),
|
|
/// save it back and diff the resulting XML file against the input
|
|
/// file. They should be identical.
|
|
|
|
#include <string>
|
|
#include <fstream>
|
|
#include <iostream>
|
|
#include <cstdlib>
|
|
#include "abg-ir.h"
|
|
#include "abg-reader.h"
|
|
#include "abg-writer.h"
|
|
#include "abg-tools-utils.h"
|
|
#include "test-utils.h"
|
|
|
|
using std::string;
|
|
using std::ofstream;
|
|
using std::cerr;
|
|
|
|
using abigail::tools::file_type;
|
|
using abigail::tools::check_file;
|
|
using abigail::tools::guess_file_type;
|
|
using abigail::translation_unit;
|
|
using abigail::corpus_sptr;
|
|
using abigail::xml_reader::read_translation_unit_from_file;
|
|
using abigail::xml_reader::read_corpus_from_native_xml_file;
|
|
using abigail::xml_writer::write_translation_unit;
|
|
using abigail::xml_writer::write_corpus_to_native_xml;
|
|
|
|
/// This is an aggregate that specifies where a test shall get its
|
|
/// input from, and where it shall write its ouput to.
|
|
struct InOutSpec
|
|
{
|
|
const char* in_path;
|
|
const char* out_path;
|
|
};// end struct InOutSpec
|
|
|
|
|
|
InOutSpec in_out_specs[] =
|
|
{
|
|
{
|
|
"data/test-read-write/test0.xml",
|
|
"output/test-read-write/test0.xml"
|
|
},
|
|
{
|
|
"data/test-read-write/test1.xml",
|
|
"output/test-read-write/test1.xml"
|
|
},
|
|
{
|
|
"data/test-read-write/test2.xml",
|
|
"output/test-read-write/test2.xml"
|
|
},
|
|
{
|
|
"data/test-read-write/test3.xml",
|
|
"output/test-read-write/test3.xml"
|
|
},
|
|
{
|
|
"data/test-read-write/test4.xml",
|
|
"output/test-read-write/test4.xml"
|
|
},
|
|
{
|
|
"data/test-read-write/test5.xml",
|
|
"output/test-read-write/test5.xml"
|
|
},
|
|
{
|
|
"data/test-read-write/test6.xml",
|
|
"output/test-read-write/test6.xml"
|
|
},
|
|
{
|
|
"data/test-read-write/test7.xml",
|
|
"output/test-read-write/test7.xml"
|
|
},
|
|
{
|
|
"data/test-read-write/test8.xml",
|
|
"output/test-read-write/test8.xml"
|
|
},
|
|
{
|
|
"data/test-read-write/test9.xml",
|
|
"output/test-read-write/test9.xml"
|
|
},
|
|
{
|
|
"data/test-read-write/test10.xml",
|
|
"output/test-read-write/test10.xml"
|
|
},
|
|
{
|
|
"data/test-read-write/test11.xml",
|
|
"output/test-read-write/test11.xml"
|
|
},
|
|
{
|
|
"data/test-read-write/test12.xml",
|
|
"output/test-read-write/test12.xml"
|
|
},
|
|
{
|
|
"data/test-read-write/test13.xml",
|
|
"output/test-read-write/test13.xml"
|
|
},
|
|
{
|
|
"data/test-read-write/test14.xml",
|
|
"output/test-read-write/test14.xml"
|
|
},
|
|
{
|
|
"data/test-read-write/test15.xml",
|
|
"output/test-read-write/test15.xml"
|
|
},
|
|
{
|
|
"data/test-read-write/test16.xml",
|
|
"output/test-read-write/test16.xml"
|
|
},
|
|
{
|
|
"data/test-read-write/test17.xml",
|
|
"output/test-read-write/test17.xml"
|
|
},
|
|
{
|
|
"data/test-read-write/test18.xml",
|
|
"output/test-read-write/test18.xml"
|
|
},
|
|
{
|
|
"data/test-read-write/test19.xml",
|
|
"output/test-read-write/test19.xml"
|
|
},
|
|
{
|
|
"data/test-read-write/test20.xml",
|
|
"output/test-read-write/test20.xml"
|
|
},
|
|
{
|
|
"data/test-read-write/test21.xml",
|
|
"output/test-read-write/test21.xml"
|
|
},
|
|
{
|
|
"data/test-read-write/test22.xml",
|
|
"output/test-read-write/test22.xml"
|
|
},
|
|
{
|
|
"data/test-read-write/test23.xml",
|
|
"output/test-read-write/test23.xml"
|
|
},
|
|
{
|
|
"data/test-read-write/test24.xml",
|
|
"output/test-read-write/test24.xml"
|
|
},
|
|
{
|
|
"data/test-read-write/test25.xml",
|
|
"output/test-read-write/test25.xml"
|
|
},
|
|
{
|
|
"data/test-read-write/test26.xml",
|
|
"output/test-read-write/test26.xml"
|
|
},
|
|
// This should be the last entry.
|
|
{NULL, NULL}
|
|
};
|
|
|
|
/// Walk the array of InOutSpecs above, read the input files it points
|
|
/// to, write it into the output it points to and diff them.
|
|
int
|
|
main()
|
|
{
|
|
unsigned result = 1;
|
|
|
|
bool is_ok = true;
|
|
string in_path, out_path;
|
|
for (InOutSpec* s = in_out_specs; s->in_path; ++s)
|
|
{
|
|
string input_suffix(s->in_path);
|
|
in_path = abigail::tests::get_src_dir() + "/tests/" + input_suffix;
|
|
|
|
if (!check_file(in_path, cerr))
|
|
return true;
|
|
|
|
translation_unit tu(in_path);
|
|
corpus_sptr corpus;
|
|
|
|
bool read = false;
|
|
file_type t = guess_file_type(in_path);
|
|
if (t == abigail::tools::FILE_TYPE_NATIVE_BI)
|
|
read = read_translation_unit_from_file(tu);
|
|
else if (t == abigail::tools::FILE_TYPE_XML_CORPUS)
|
|
read = (corpus = read_corpus_from_native_xml_file(in_path));
|
|
else
|
|
abort();
|
|
if (!read)
|
|
{
|
|
cerr << "failed to read " << in_path << "\n";
|
|
is_ok = false;
|
|
continue;
|
|
}
|
|
|
|
string output_suffix(s->out_path);
|
|
out_path = abigail::tests::get_build_dir() + "/tests/" + output_suffix;
|
|
if (!abigail::tools::ensure_parent_dir_created(out_path))
|
|
{
|
|
cerr << "Could not create parent director for " << out_path;
|
|
is_ok = false;
|
|
return result;
|
|
}
|
|
|
|
ofstream of(out_path.c_str(), std::ios_base::trunc);
|
|
if (!of.is_open())
|
|
{
|
|
cerr << "failed to read " << out_path << "\n";
|
|
is_ok = false;
|
|
continue;
|
|
}
|
|
|
|
bool r = false;
|
|
|
|
if (t == abigail::tools::FILE_TYPE_XML_CORPUS)
|
|
r = write_corpus_to_native_xml(corpus, /*indent=*/0, of);
|
|
else if (t == abigail::tools::FILE_TYPE_NATIVE_BI)
|
|
r = write_translation_unit(tu, /*indent=*/0, of);
|
|
else
|
|
abort();
|
|
|
|
is_ok = (is_ok && r);
|
|
of.close();
|
|
string cmd = "diff -u " + in_path + " " + out_path;
|
|
if (system(cmd.c_str()))
|
|
is_ok = false;
|
|
}
|
|
|
|
return !is_ok;
|
|
}
|