RepoMirrors/libabigail
1
0
Fork 0
mirror of git://sourceware.org/git/libabigail.git synced 2024-12-21 01:09:59 +00:00
Code Issues Packages Projects Releases Wiki Activity
68f4f35246
libabigail/tests/test-diff-suppr.cc
Dodji Seketeli 0cd814766b Support new 'accessed_through' suppression property 
It turned out it's important to be able to suppress changes about
types that are reachable from a function parameter only through e.g, a
pointer or a reference, so that only changes types that are reachable
directly from a function parameter are emitted.

This patch adds that feature.

While doing this, I noticed this: Suppose a diff node D2 is marked as
being redundant with a diff node D1 seen previously.  So only D1 is
reported; D2 is not, because it's been filtered out, because it's
redundant with D1.  But then suppose D1 is filtered out, due to a
suppression specification.  At that point, D2 should not be marked
redundant anymore, and should be reported.

Of course, the code before this patch was wrongly filtering D2 *and*
D1 out.  So this patch fixes that.

	* include/abg-comparison.h (enum type_suppression::reach_kind):
	Define new enum.
	(type_suppression::{get_consider_reach_kind,
	set_consider_reach_kind, get_reach_kind,
	mark_last_diff_visited_per_class_of_equivalence,
	clear_last_diffs_visited_per_class_of_equivalence,
	get_last_visited_diff_of_class_of_equivalence}): Declare new
	member functions.
	* src/abg-comparison.cc (diff_has_ancestor_filtered_out)
	(read_suppression_reach_kind): Define static function.
	(type_suppression::priv::{consider_reach_kind_, reach_kind_}):
	Define new data members.
	(type_suppression::priv::priv): Take a new reach_kind parameter.
	(type_suppression::type_suppression): Adjust to new prototype of
	priv constructor.
	(type_suppression::{get_consider_reach_kind,
	set_consider_reach_kind, get_reach_kind, set_reach_kind}): Define
	new member functions.
	(type_suppression::suppresses_diff): Interpret the result of
	type_suppression::get_reach_kind() to determine if the suppression
	specification suppresses a given diff node.
	(read_type_suppression): Support reading the content of the
	"accessed_through" property.
	(diff_context::priv::last_visited_diff_node_): New data member.
	(diff_context::{mark_last_diff_visited_per_class_of_equivalence,
	clear_last_diffs_visited_per_class_of_equivalence,
	get_last_visited_diff_of_class_of_equivalence}): Define new data
	members.
	(redundancy_marking_visitor::visit_begin): So if the current diff
	node has already been visited, but if the previously visited node
	has been filtered out, then do not mark this node as being
	redundant.  And mark the current diff node as being the last
	visited one in its class of equivalence.
	(categorize_redundancy): Clear the map of diff nodes visited per
	class of equivalence.
	* doc/manuals/libabigail-concepts.rst: Document the new
	'accessed_through' property.
	* tests/data/test-diff-suppr/test13-suppr-through-pointer-0.suppr:
	New test input data.
	* tests/data/test-diff-suppr/test13-suppr-through-pointer-report-{0,1}.txt:
	Likewise.
	* tests/data/test-diff-suppr/libtest13-suppr-through-pointer-v{0,1}.so:
	New test input binaries.
	* tests/data/test-diff-suppr/test13-suppr-through-pointer-v{0,1}.cc:
	Source code of the test input binaries above.
	* tests/data/test-diff-suppr/test14-suppr-non-redundant-0.suppr:
	New test input data.
	* tests/data/test-diff-suppr/test14-suppr-non-redundant-report-0.txt:
	Likewise.
	* tests/data/test-diff-suppr/test14-suppr-non-redundant-v{0,1}.o:
	New test input binaries.
	* tests/data/test-diff-suppr/test14-suppr-non-redundant-v{0,1}.cc:
	Source code of the binaries above.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>
2015-06-04 13:29:32 +02:00

532 lines
19 KiB
C++
Raw Blame History

// -*- Mode: C++ -*-
//
// Copyright (C) 2013-2015 Red Hat, Inc.
//
// This file is part of the GNU Application Binary Interface Generic
// Analysis and Instrumentation Library (libabigail). This library is
// free software; you can redistribute it and/or modify it under the
// terms of the GNU Lesser General Public License as published by the
// Free Software Foundation; either version 3, or (at your option) any
// later version.
// This library is distributed in the hope that it will be useful, but
// WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
// General Lesser Public License for more details.
// You should have received a copy of the GNU Lesser General Public
// License along with this program; see the file COPYING-LGPLV3. If
// not, see <http://www.gnu.org/licenses/>.
// Author: Dodji Seketeli
/// @file
///
/// This test harness program runs a diff between input ELF files
/// containing DWARF debugging information, exercising the
/// suppressions features of the "bidiff" command line program.
///
/// So it runs the diff diff between the two input files, using a
/// suppression file and compares the resulting diff with a reference
/// one.
#include <cstring>
#include <string>
#include <fstream>
#include <iostream>
#include <cstdlib>
#include "abg-tools-utils.h"
#include "test-utils.h"
using std::string;
using std::cerr;
/// This is an aggregate that specifies where a test shall get its
/// input from and where it shall write its ouput to.
struct InOutSpec
{
const char* in_elfv0_path;
const char* in_elfv1_path;
const char* in_suppr_path;
const char* bidiff_options;
const char* in_report_path;
const char* out_report_path;
}; // end struct InOutSpec;
InOutSpec in_out_specs[] =
{
{
"data/test-diff-suppr/test0-type-suppr-v0.o",
"data/test-diff-suppr/test0-type-suppr-v1.o",
NULL,
"--no-redundant",
"data/test-diff-suppr/test0-type-suppr-report-0.txt",
"output/test-diff-suppr/test0-type-suppr-report-0.txt",
},
{
"data/test-diff-suppr/test0-type-suppr-v0.o",
"data/test-diff-suppr/test0-type-suppr-v1.o",
"data/test-diff-suppr/test0-type-suppr-0.suppr",
"--no-redundant",
"data/test-diff-suppr/test0-type-suppr-report-1.txt",
"output/test-diff-suppr/test0-type-suppr-report-1.txt",
},
{
"data/test-diff-suppr/test0-type-suppr-v0.o",
"data/test-diff-suppr/test0-type-suppr-v1.o",
"data/test-diff-suppr/test0-type-suppr-1.suppr",
"--no-redundant",
"data/test-diff-suppr/test0-type-suppr-report-2.txt",
"output/test-diff-suppr/test0-type-suppr-report-2.txt",
},
{
"data/test-diff-suppr/test0-type-suppr-v0.o",
"data/test-diff-suppr/test0-type-suppr-v1.o",
"data/test-diff-suppr/test0-type-suppr-2.suppr",
"--no-redundant",
"data/test-diff-suppr/test0-type-suppr-report-3.txt",
"output/test-diff-suppr/test0-type-suppr-report-3.txt",
},
{
"data/test-diff-suppr/test1-typedef-suppr-v0.o",
"data/test-diff-suppr/test1-typedef-suppr-v1.o",
"",
"--no-redundant",
"data/test-diff-suppr/test1-typedef-suppr-report-0.txt",
"output/test-diff-suppr/test1-typedef-suppr-report-0.txt",
},
{
"data/test-diff-suppr/test1-typedef-suppr-v0.o",
"data/test-diff-suppr/test1-typedef-suppr-v1.o",
"data/test-diff-suppr/test1-typedef-suppr-0.suppr",
"--no-redundant",
"data/test-diff-suppr/test1-typedef-suppr-report-1.txt",
"output/test-diff-suppr/test1-typedef-suppr-report-1.txt",
},
{
"data/test-diff-suppr/test1-typedef-suppr-v0.o",
"data/test-diff-suppr/test1-typedef-suppr-v1.o",
"data/test-diff-suppr/test1-typedef-suppr-1.suppr",
"--no-redundant",
"data/test-diff-suppr/test1-typedef-suppr-report-2.txt",
"output/test-diff-suppr/test1-typedef-suppr-report-2.txt",
},
{
"data/test-diff-suppr/test2-struct-suppr-v0.o",
"data/test-diff-suppr/test2-struct-suppr-v1.o",
"data/test-diff-suppr/test2-struct-suppr-0.suppr",
"--no-redundant",
"data/test-diff-suppr/test2-struct-suppr-report-0.txt",
"output/test-diff-suppr/test2-struct-suppr-report-0.txt",
},
{
"data/test-diff-suppr/test2-struct-suppr-v0.o",
"data/test-diff-suppr/test2-struct-suppr-v1.o",
"data/test-diff-suppr/test2-struct-suppr-1.suppr",
"--no-redundant",
"data/test-diff-suppr/test2-struct-suppr-report-1.txt",
"output/test-diff-suppr/test2-struct-suppr-report-1.txt",
},
{
"data/test-diff-suppr/test3-struct-suppr-v0.o",
"data/test-diff-suppr/test3-struct-suppr-v1.o",
NULL,
"--no-redundant",
"data/test-diff-suppr/test3-struct-suppr-report-0.txt",
"output/test-diff-suppr/test3-struct-suppr-report-0.txt",
},
{
"data/test-diff-suppr/test3-struct-suppr-v0.o",
"data/test-diff-suppr/test3-struct-suppr-v1.o",
"data/test-diff-suppr/test3-struct-suppr-0.suppr",
"--no-redundant",
"data/test-diff-suppr/test3-struct-suppr-report-1.txt",
"output/test-diff-suppr/test3-struct-suppr-report-1.txt",
},
{
"data/test-diff-suppr/test3-struct-suppr-v0.o",
"data/test-diff-suppr/test3-struct-suppr-v1.o",
"data/test-diff-suppr/test3-struct-suppr-1.suppr",
"--no-redundant",
"data/test-diff-suppr/test3-struct-suppr-report-2.txt",
"output/test-diff-suppr/test3-struct-suppr-report-2.txt",
},
{
"data/test-diff-suppr/libtest4-local-suppr-v0.so",
"data/test-diff-suppr/libtest4-local-suppr-v1.so",
"data/test-diff-suppr/test4-local-suppr-0.suppr",
"--no-redundant",
"data/test-diff-suppr/test4-local-suppr-report-1.txt",
"output/test-diff-suppr/test4-local-suppr-report-1.txt",
},
{
"data/test-diff-suppr/libtest4-local-suppr-v0.so",
"data/test-diff-suppr/libtest4-local-suppr-v1.so",
"",
"",
"data/test-diff-suppr/test4-local-suppr-report-0.txt",
"output/test-diff-suppr/test4-local-suppr-report-0.txt",
},
{
"data/test-diff-suppr/libtest5-fn-suppr-v0.so",
"data/test-diff-suppr/libtest5-fn-suppr-v1.so",
"",
"--no-redundant",
"data/test-diff-suppr/test5-fn-suppr-report-0.txt",
"output/test-diff-suppr/test5-fn-suppr-report-0.txt",
},
{
"data/test-diff-suppr/libtest5-fn-suppr-v0.so",
"data/test-diff-suppr/libtest5-fn-suppr-v1.so",
"data/test-diff-suppr/test5-fn-suppr-0.suppr",
"--no-redundant",
"data/test-diff-suppr/test5-fn-suppr-report-1.txt",
"output/test-diff-suppr/test5-fn-suppr-report-1.txt",
},
{
"data/test-diff-suppr/libtest5-fn-suppr-v0.so",
"data/test-diff-suppr/libtest5-fn-suppr-v1.so",
"data/test-diff-suppr/test5-fn-suppr-1.suppr",
"--no-redundant",
"data/test-diff-suppr/test5-fn-suppr-report-2.txt",
"output/test-diff-suppr/test5-fn-suppr-report-2.txt",
},
{
"data/test-diff-suppr/libtest5-fn-suppr-v0.so",
"data/test-diff-suppr/libtest5-fn-suppr-v1.so",
"data/test-diff-suppr/test5-fn-suppr-2.suppr",
"--no-redundant",
"data/test-diff-suppr/test5-fn-suppr-report-3.txt",
"output/test-diff-suppr/test5-fn-suppr-report-3.txt",
},
{
"data/test-diff-suppr/libtest5-fn-suppr-v0.so",
"data/test-diff-suppr/libtest5-fn-suppr-v1.so",
"data/test-diff-suppr/test5-fn-suppr-3.suppr",
"--no-redundant",
"data/test-diff-suppr/test5-fn-suppr-report-4.txt",
"output/test-diff-suppr/test5-fn-suppr-report-4.txt",
},
{
"data/test-diff-suppr/libtest5-fn-suppr-v0.so",
"data/test-diff-suppr/libtest5-fn-suppr-v1.so",
"data/test-diff-suppr/test5-fn-suppr-4.suppr",
"--no-redundant",
"data/test-diff-suppr/test5-fn-suppr-report-5.txt",
"output/test-diff-suppr/test5-fn-suppr-report-5.txt",
},
{
"data/test-diff-suppr/libtest6-fn-suppr-v0.so",
"data/test-diff-suppr/libtest6-fn-suppr-v1.so",
"",
"--no-redundant",
"data/test-diff-suppr/test6-fn-suppr-report-0.txt",
"output/test-diff-suppr/test6-fn-suppr-report-0.txt",
},
{
"data/test-diff-suppr/libtest6-fn-suppr-v0.so",
"data/test-diff-suppr/libtest6-fn-suppr-v1.so",
"data/test-diff-suppr/test6-fn-suppr-0.suppr",
"--no-redundant",
"data/test-diff-suppr/test6-fn-suppr-report-1.txt",
"output/test-diff-suppr/test6-fn-suppr-report-1.txt",
},
{
"data/test-diff-suppr/libtest6-fn-suppr-v0.so",
"data/test-diff-suppr/libtest6-fn-suppr-v1.so",
"data/test-diff-suppr/test6-fn-suppr-1.suppr",
"--no-redundant",
"data/test-diff-suppr/test6-fn-suppr-report-2.txt",
"output/test-diff-suppr/test6-fn-suppr-report-2.txt",
},
{
"data/test-diff-suppr/libtest6-fn-suppr-v0.so",
"data/test-diff-suppr/libtest6-fn-suppr-v1.so",
"data/test-diff-suppr/test6-fn-suppr-2.suppr",
"--no-redundant",
"data/test-diff-suppr/test6-fn-suppr-report-3.txt",
"output/test-diff-suppr/test6-fn-suppr-report-3.txt",
},
{
"data/test-diff-suppr/libtest7-var-suppr-v0.so",
"data/test-diff-suppr/libtest7-var-suppr-v1.so",
"",
"--no-redundant",
"data/test-diff-suppr/test7-var-suppr-report-0.txt",
"output/test-diff-suppr/test7-var-suppr-report-0.txt"
},
{
"data/test-diff-suppr/libtest7-var-suppr-v0.so",
"data/test-diff-suppr/libtest7-var-suppr-v1.so",
"data/test-diff-suppr/test7-var-suppr-1.suppr",
"--no-redundant",
"data/test-diff-suppr/test7-var-suppr-report-1.txt",
"output/test-diff-suppr/test7-var-suppr-report-1.txt"
},
{
"data/test-diff-suppr/libtest7-var-suppr-v0.so",
"data/test-diff-suppr/libtest7-var-suppr-v1.so",
"data/test-diff-suppr/test7-var-suppr-2.suppr",
"--no-redundant",
"data/test-diff-suppr/test7-var-suppr-report-2.txt",
"output/test-diff-suppr/test7-var-suppr-report-2.txt"
},
{
"data/test-diff-suppr/libtest7-var-suppr-v0.so",
"data/test-diff-suppr/libtest7-var-suppr-v1.so",
"data/test-diff-suppr/test7-var-suppr-3.suppr",
"--no-redundant",
"data/test-diff-suppr/test7-var-suppr-report-3.txt",
"output/test-diff-suppr/test7-var-suppr-report-3.txt"
},
{
"data/test-diff-suppr/libtest7-var-suppr-v0.so",
"data/test-diff-suppr/libtest7-var-suppr-v1.so",
"data/test-diff-suppr/test7-var-suppr-4.suppr",
"--no-redundant",
"data/test-diff-suppr/test7-var-suppr-report-4.txt",
"output/test-diff-suppr/test7-var-suppr-report-4.txt"
},
{
"data/test-diff-suppr/libtest7-var-suppr-v0.so",
"data/test-diff-suppr/libtest7-var-suppr-v1.so",
"data/test-diff-suppr/test7-var-suppr-5.suppr",
"--no-redundant",
"data/test-diff-suppr/test7-var-suppr-report-5.txt",
"output/test-diff-suppr/test7-var-suppr-report-5.txt"
},
{
"data/test-diff-suppr/libtest7-var-suppr-v0.so",
"data/test-diff-suppr/libtest7-var-suppr-v1.so",
"data/test-diff-suppr/test7-var-suppr-6.suppr",
"--no-redundant",
"data/test-diff-suppr/test7-var-suppr-report-6.txt",
"output/test-diff-suppr/test7-var-suppr-report-6.txt"
},
{
"data/test-diff-suppr/libtest7-var-suppr-v0.so",
"data/test-diff-suppr/libtest7-var-suppr-v1.so",
"data/test-diff-suppr/test7-var-suppr-7.suppr",
"--no-redundant",
"data/test-diff-suppr/test7-var-suppr-report-7.txt",
"output/test-diff-suppr/test7-var-suppr-report-7.txt"
},
{
"data/test-diff-suppr/libtest7-var-suppr-v0.so",
"data/test-diff-suppr/libtest7-var-suppr-v1.so",
"data/test-diff-suppr/test7-var-suppr-8.suppr",
"--no-redundant",
"data/test-diff-suppr/test7-var-suppr-report-8.txt",
"output/test-diff-suppr/test7-var-suppr-report-8.txt"
},
{
"data/test-diff-suppr/libtest8-redundant-fn-v0.so",
"data/test-diff-suppr/libtest8-redundant-fn-v1.so",
"",
"--no-redundant",
"data/test-diff-suppr/test8-redundant-fn-report-0.txt",
"output/test-diff-suppr/test8-redundant-fn-report-0.txt"
},
{
"data/test-diff-suppr/libtest8-redundant-fn-v0.so",
"data/test-diff-suppr/libtest8-redundant-fn-v1.so",
"",
"--redundant",
"data/test-diff-suppr/test8-redundant-fn-report-1.txt",
"output/test-diff-suppr/test8-redundant-fn-report-1.txt"
},
{
"data/test-diff-suppr/libtest9-changed-parm-c-v0.so",
"data/test-diff-suppr/libtest9-changed-parm-c-v1.so",
"",
"--no-redundant",
"data/test-diff-suppr/test9-changed-parm-c-report-0.txt",
"output/test-diff-suppr/est9-changed-parm-c-report-0.txt"
},
{
"data/test-diff-suppr/libtest9-changed-parm-c-v0.so",
"data/test-diff-suppr/libtest9-changed-parm-c-v1.so",
"",
"--redundant",
"data/test-diff-suppr/test9-changed-parm-c-report-1.txt",
"output/test-diff-suppr/est9-changed-parm-c-report-1.txt"
},
{
"data/test-diff-suppr/libtest10-changed-parm-c-v0.so",
"data/test-diff-suppr/libtest10-changed-parm-c-v1.so",
"",
"--no-redundant",
"data/test-diff-suppr/test10-changed-parm-c-report-0.txt",
"output/test-diff-suppr/test10-changed-parm-c-report-0.txt"
},
{
"data/test-diff-suppr/libtest11-add-data-member-v0.so",
"data/test-diff-suppr/libtest11-add-data-member-v1.so",
"",
"--no-redundant",
"data/test-diff-suppr/test11-add-data-member-report-0.txt",
"output/test-diff-suppr/test11-add-data-member-report-0.txt"
},
{
"data/test-diff-suppr/libtest11-add-data-member-v0.so",
"data/test-diff-suppr/libtest11-add-data-member-v1.so",
"data/test-diff-suppr/test11-add-data-member-0.suppr",
"--no-redundant",
"data/test-diff-suppr/test11-add-data-member-report-1.txt",
"output/test-diff-suppr/test11-add-data-member-report-1.txt"
},
{
"data/test-diff-suppr/libtest11-add-data-member-v0.so",
"data/test-diff-suppr/libtest11-add-data-member-v1.so",
"data/test-diff-suppr/test11-add-data-member-1.suppr",
"--no-redundant",
"data/test-diff-suppr/test11-add-data-member-report-1.txt",
"output/test-diff-suppr/test11-add-data-member-report-1.txt"
},
{
"data/test-diff-suppr/libtest11-add-data-member-v0.so",
"data/test-diff-suppr/libtest11-add-data-member-v1.so",
"data/test-diff-suppr/test11-add-data-member-2.suppr",
"--no-redundant",
"data/test-diff-suppr/test11-add-data-member-report-1.txt",
"output/test-diff-suppr/test11-add-data-member-report-1.txt"
},
{
"data/test-diff-suppr/libtest11-add-data-member-v0.so",
"data/test-diff-suppr/libtest11-add-data-member-v1.so",
"data/test-diff-suppr/test11-add-data-member-3.suppr",
"--no-redundant",
"data/test-diff-suppr/test11-add-data-member-report-1.txt",
"output/test-diff-suppr/test11-add-data-member-report-1.txt"
},
{
"data/test-diff-suppr/libtest11-add-data-member-v0.so",
"data/test-diff-suppr/libtest11-add-data-member-v1.so",
"data/test-diff-suppr/test11-add-data-member-4.suppr",
"--no-redundant",
"data/test-diff-suppr/test11-add-data-member-report-1.txt",
"output/test-diff-suppr/test11-add-data-member-report-1.txt"
},
{
"data/test-diff-suppr/libtest12-add-data-member-v0.so",
"data/test-diff-suppr/libtest12-add-data-member-v1.so",
"",
"--no-redundant",
"data/test-diff-suppr/test12-add-data-member-report-0.txt",
"output/test-diff-suppr/test12-add-data-member-report-0.txt"
},
{
"data/test-diff-suppr/libtest12-add-data-member-v0.so",
"data/test-diff-suppr/libtest12-add-data-member-v1.so",
"data/test-diff-suppr/test12-add-data-member-0.suppr",
"--no-redundant",
"data/test-diff-suppr/test12-add-data-member-report-1.txt",
"output/test-diff-suppr/test12-add-data-member-report-1.txt"
},
{
"data/test-diff-suppr/libtest12-add-data-member-v0.so",
"data/test-diff-suppr/libtest12-add-data-member-v1.so",
"data/test-diff-suppr/test12-add-data-member-1.suppr",
"--no-redundant",
"data/test-diff-suppr/test12-add-data-member-report-2.txt",
"output/test-diff-suppr/test12-add-data-member-report-2.txt"
},
{
"data/test-diff-suppr/libtest13-suppr-through-pointer-v0.so",
"data/test-diff-suppr/libtest13-suppr-through-pointer-v1.so",
"",
"--no-redundant",
"data/test-diff-suppr/test13-suppr-through-pointer-report-0.txt",
"output/test-diff-suppr/test13-suppr-through-pointer-report-0.txt"
},
{
"data/test-diff-suppr/libtest13-suppr-through-pointer-v0.so",
"data/test-diff-suppr/libtest13-suppr-through-pointer-v1.so",
"data/test-diff-suppr/test13-suppr-through-pointer-0.suppr",
"--no-redundant",
"data/test-diff-suppr/test13-suppr-through-pointer-report-1.txt",
"output/test-diff-suppr/test13-suppr-through-pointer-report-1.txt"
},
{
"data/test-diff-suppr/test14-suppr-non-redundant-v0.o",
"data/test-diff-suppr/test14-suppr-non-redundant-v1.o",
"",
"--no-redundant",
"data/test-diff-suppr/test14-suppr-non-redundant-report-0.txt",
"output/test-diff-suppr/test14-suppr-non-redundant-report-0.txt"
},
{
"data/test-diff-suppr/test14-suppr-non-redundant-v0.o",
"data/test-diff-suppr/test14-suppr-non-redundant-v1.o",
"data/test-diff-suppr/test14-suppr-non-redundant-0.suppr",
"--no-redundant",
"data/test-diff-suppr/test14-suppr-non-redundant-report-1.txt",
"output/test-diff-suppr/test14-suppr-non-redundant-report-1.txt"
},
// This should be the last entry
{NULL, NULL, NULL, NULL, NULL, NULL}
};
int
main()
{
using abigail::tests::get_src_dir;
using abigail::tests::get_build_dir;
using abigail::tools_utils::ensure_parent_dir_created;
using abigail::tools_utils::abidiff_status;
bool is_ok = true;
string in_elfv0_path, in_elfv1_path,
in_suppression_path, bidiff_options, bidiff, cmd,
ref_diff_report_path, out_diff_report_path;
for (InOutSpec* s = in_out_specs; s->in_elfv0_path; ++s)
{
in_elfv0_path = get_src_dir() + "/tests/" + s->in_elfv0_path;
in_elfv1_path = get_src_dir() + "/tests/" + s->in_elfv1_path;
if (s->in_suppr_path && strcmp(s->in_suppr_path, ""))
in_suppression_path = get_src_dir() + "/tests/" + s->in_suppr_path;
else
in_suppression_path.clear();
bidiff_options = s->bidiff_options;
ref_diff_report_path = get_src_dir() + "/tests/" + s->in_report_path;
out_diff_report_path = get_build_dir() + "/tests/" + s->out_report_path;
if (!ensure_parent_dir_created(out_diff_report_path))
{
cerr << "could not create parent directory for "
<< out_diff_report_path;
is_ok = false;
continue;
}
bidiff = get_build_dir() + "/tools/abidiff";
bidiff += " " + bidiff_options;
if (!in_suppression_path.empty())
bidiff += " --suppressions " + in_suppression_path;
cmd = bidiff + " " + in_elfv0_path + " " + in_elfv1_path;
cmd += " > " + out_diff_report_path;
bool bidiff_ok = true;
abigail::tools_utils::abidiff_status status =
static_cast<abidiff_status>(system(cmd.c_str()) & 255);
if (abigail::tools_utils::abidiff_status_has_error(status))
bidiff_ok = false;
if (bidiff_ok)
{
cmd = "diff -u " + ref_diff_report_path
+ " " + out_diff_report_path;
if (system(cmd.c_str()))
is_ok = false;
}
else
is_ok = false;
}
return !is_ok;
}
Reference in New Issue View Git Blame Copy Permalink