mirror of
git://sourceware.org/git/libabigail.git
synced 2024-12-13 21:44:52 +00:00
06fa2fd968
Looking at the result of builds on various platforms, it appears that
the order of the method change reports in the
test29-vtable-changes-report-0.txt of runtestdiffdwarf was not stable
across all platforms. debian-armhf was exhibiting this change in
output, for instance:
--- /var/lib/buildbot/workers/wildebeest/libabigail-try-debian-armhf/build/tests/data/test-diff-dwarf/test29-vtable-changes-report-0.txt
2024-03-04 08:56:42.307366590 +0000
+++ /var/lib/buildbot/workers/wildebeest/libabigail-try-debian-armhf/build/tests/output/test-diff-dwarf/test29-vtable-changes-report-0.txt
2024-03-04 09:20:22.146334907 +0000
@@ -19,13 +19,13 @@
implicit parameter 0 of type 'S* const' has sub-type
changes:
in unqualified underlying type 'S*':
pointed to type 'struct S' changed, as being reported
+ 'method virtual S::~S(int)' has some sub-type changes:
+ implicit parameter 0 of type 'S*' has sub-type changes:
+ pointed to type 'struct S' changed, as being reported
'method virtual S::~S()' has some sub-type changes:
implicit parameter 0 of type 'S* const' has sub-type
changes:
in unqualified underlying type 'S*':
pointed to type 'struct S' changed, as being reported
- 'method virtual S::~S(int)' has some sub-type changes:
- implicit parameter 0 of type 'S*' has sub-type changes:
- pointed to type 'struct S' changed, as being reported
'method virtual void S::fn0()' has some sub-type changes:
implicit parameter 0 of type 'S*' has sub-type changes:
pointed to type 'struct S' changed, as being reported
Better handling the sorting of function changes should hopefully fix
this issue.
* src/abg-comparison-priv.h (is_less_than): Declare new helper
function.
(function_decl_diff_comp::operator(const function_decl_diff&,
const function_decl_diff&)):
Use it here.
(virtual_member_function_diff_comp::operator(const function_decl_diff&,
const function_decl_diff&)):
Likewise.
* tests/data/test-abidiff/test-PR18791-report0.txt: Adjust.
* tests/data/test-diff-dwarf/test29-vtable-changes-report-0.txt:
Adjust.
* tests/data/test-diff-dwarf/test30-vtable-changes-report-0.txt:
Adjust.
* tests/data/test-diff-dwarf/test31-vtable-changes-report-0.txt:
Adjust.
* tests/data/test-diff-dwarf/test41-PR20476-hidden-report-0.txt:
Adjust.
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
|
||
|---|---|---|
| .. | ||
| empty-report.txt | ||
| test-crc-0.xml | ||
| test-crc-1.xml | ||
| test-crc-2.xml | ||
| test-crc-report-0-1.txt | ||
| test-crc-report-1-0.txt | ||
| test-crc-report-1-2.txt | ||
| test-empty-corpus-0.xml | ||
| test-empty-corpus-1.xml | ||
| test-empty-corpus-2.xml | ||
| test-enum0-report.txt | ||
| test-enum0-v0.cc.bi | ||
| test-enum0-v1.cc.bi | ||
| test-enum1-report.txt | ||
| test-enum1-v0.cc.bi | ||
| test-enum1-v1.cc.bi | ||
| test-namespace-0.xml | ||
| test-namespace-1.xml | ||
| test-namespace-report.txt | ||
| test-PR18166-libtirpc.so | ||
| test-PR18166-libtirpc.so.abi | ||
| test-PR18791-report0.txt | ||
| test-PR18791-v0.so.abi | ||
| test-PR18791-v1.so.abi | ||
| test-PR24552-v0.abi | ||
| test-PR24552-v1.abi | ||
| test-PR27616-squished-v0.abi | ||
| test-PR27616-squished-v1.abi | ||
| test-PR27616-v0.xml | ||
| test-PR27616-v1.xml | ||
| test-PR27985-report.txt | ||
| test-PR27985-v0.c | ||
| test-PR27985-v0.o | ||
| test-PR27985-v0.o.abi | ||
| test-PR27985-v1.c | ||
| test-PR27985-v1.o | ||
| test-PR27985-v1.o.abi | ||
| test-qual-type0-report.txt | ||
| test-qual-type0-v0.cc.bi | ||
| test-qual-type0-v1.cc.bi | ||
| test-struct0-report.txt | ||
| test-struct0-v0.cc.bi | ||
| test-struct0-v1.cc.bi | ||
| test-struct1-report.txt | ||
| test-struct1-v0.cc.bi | ||
| test-struct1-v1.cc.bi | ||
| test-var0-report.txt | ||
| test-var0-v0.cc.bi | ||
| test-var0-v1.cc.bi | ||