libabigail/tests/test-kmi-whitelist.cc
Giuliano Procida 186cc9ed3a Simplify generation of symbol whitelist regex.
The code to build the symbol whitelist regex uses things like seekp
and tellp to generate regexes like "^foo$|^bar$".

This patch simplifies the code, for further enhancement, resulting in
generated regexes like "^(foo|bar)$".

There should be no change in behaviour, unless whitelisted symbol
names contain special regex characters.

	* include/abg-regex.h (generate_from_strings): Declare new
	function to build a regex from some strings, representing a
	membership test.
	* src/abg-regex.cc (generate_from_strings): Implement new
	function to build a regex from some strings, representing a
	membership test, in a straightfoward fashion.
	* src/abg-tools-utils.cc
	(gen_suppr_spec_from_kernel_abi_whitelists): Replace
	regex-building code with a call to generate_from_strings.
	* tests/test-kmi-whitelist.cc: Update regexes in test.

Signed-off-by: Giuliano Procida <gprocida@google.com>
2020-05-04 11:17:49 +02:00

145 lines
5.0 KiB
C++

// -*- Mode: C++ -*-
//
// Copyright (C) 2020 Google, Inc.
//
// This file is part of the GNU Application Binary Interface Generic
// Analysis and Instrumentation Library (libabigail). This library is
// free software; you can redistribute it and/or modify it under the
// terms of the GNU Lesser General Public License as published by the
// Free Software Foundation; either version 3, or (at your option) any
// later version.
// This library is distributed in the hope that it will be useful, but
// WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
// General Lesser Public License for more details.
// You should have received a copy of the GNU Lesser General Public
// License along with this program; see the file COPYING-LGPLV3. If
// not, see <http://www.gnu.org/licenses/>.
// Author: Matthias Maennich
/// @file
///
/// This program tests suppression generation from KMI whitelists.
#include <string>
#include "lib/catch.hpp"
#include "abg-fwd.h"
#include "abg-suppression.h"
#include "abg-tools-utils.h"
#include "test-utils.h"
using abigail::tools_utils::gen_suppr_spec_from_kernel_abi_whitelists;
using abigail::suppr::suppression_sptr;
using abigail::suppr::suppressions_type;
using abigail::suppr::function_suppression_sptr;
using abigail::suppr::variable_suppression_sptr;
using abigail::suppr::is_function_suppression;
using abigail::suppr::is_variable_suppression;
const static std::string whitelist_with_single_entry
= std::string(abigail::tests::get_src_dir())
+ "/tests/data/test-kmi-whitelist/whitelist-with-single-entry";
const static std::string whitelist_with_another_single_entry
= std::string(abigail::tests::get_src_dir())
+ "/tests/data/test-kmi-whitelist/whitelist-with-another-single-entry";
const static std::string whitelist_with_two_sections
= std::string(abigail::tests::get_src_dir())
+ "/tests/data/test-kmi-whitelist/whitelist-with-two-sections";
const static std::string whitelist_with_duplicate_entry
= std::string(abigail::tests::get_src_dir())
+ "/tests/data/test-kmi-whitelist/whitelist-with-duplicate-entry";
void
test_suppressions_are_consistent(const suppressions_type& suppr,
const std::string& expr)
{
REQUIRE(suppr.size() == 2);
function_suppression_sptr left = is_function_suppression(suppr[0]);
variable_suppression_sptr right = is_variable_suppression(suppr[1]);
// correctly casted
REQUIRE(left);
REQUIRE(right);
// same label
REQUIRE(left->get_label() == right->get_label());
// same mode
REQUIRE(left->get_drops_artifact_from_ir()
== right->get_drops_artifact_from_ir());
// same regex
REQUIRE(left->get_symbol_name_not_regex_str()
== right->get_symbol_name_not_regex_str());
// regex as expected
REQUIRE(left->get_symbol_name_not_regex_str() == expr);
}
TEST_CASE("NoWhitelists", "[whitelists]")
{
const std::vector<std::string> abi_whitelist_paths;
suppressions_type suppr =
gen_suppr_spec_from_kernel_abi_whitelists(abi_whitelist_paths);
REQUIRE(suppr.empty());
}
TEST_CASE("WhitelistWithASingleEntry", "[whitelists]")
{
std::vector<std::string> abi_whitelist_paths;
abi_whitelist_paths.push_back(whitelist_with_single_entry);
suppressions_type suppr
= gen_suppr_spec_from_kernel_abi_whitelists(abi_whitelist_paths);
REQUIRE(!suppr.empty());
test_suppressions_are_consistent(suppr, "^(test_symbol)$");
}
TEST_CASE("WhitelistWithADuplicateEntry", "[whitelists]")
{
std::vector<std::string> abi_whitelist_paths;
abi_whitelist_paths.push_back(whitelist_with_duplicate_entry);
suppressions_type suppr
= gen_suppr_spec_from_kernel_abi_whitelists(abi_whitelist_paths);
REQUIRE(!suppr.empty());
test_suppressions_are_consistent(suppr, "^(test_symbol)$");
}
TEST_CASE("TwoWhitelists", "[whitelists]")
{
std::vector<std::string> abi_whitelist_paths;
abi_whitelist_paths.push_back(whitelist_with_single_entry);
abi_whitelist_paths.push_back(whitelist_with_another_single_entry);
suppressions_type suppr =
gen_suppr_spec_from_kernel_abi_whitelists(abi_whitelist_paths);
REQUIRE(!suppr.empty());
test_suppressions_are_consistent(suppr,
"^(test_another_symbol|test_symbol)$");
}
TEST_CASE("TwoWhitelistsWithDuplicates", "[whitelists]")
{
std::vector<std::string> abi_whitelist_paths;
abi_whitelist_paths.push_back(whitelist_with_duplicate_entry);
abi_whitelist_paths.push_back(whitelist_with_another_single_entry);
suppressions_type suppr
= gen_suppr_spec_from_kernel_abi_whitelists(abi_whitelist_paths);
REQUIRE(!suppr.empty());
test_suppressions_are_consistent(suppr,
"^(test_another_symbol|test_symbol)$");
}
TEST_CASE("WhitelistWithTwoSections", "[whitelists]")
{
std::vector<std::string> abi_whitelist_paths;
abi_whitelist_paths.push_back(whitelist_with_two_sections);
suppressions_type suppr
= gen_suppr_spec_from_kernel_abi_whitelists(abi_whitelist_paths);
REQUIRE(!suppr.empty());
test_suppressions_are_consistent(suppr, "^(test_symbol1|test_symbol2)$");
}