mirror of
git://sourceware.org/git/libabigail.git
synced 2025-01-22 17:23:05 +00:00
2862147c0a
This utility function compares qualified names component-wise with
special handling of components that are anonymous names.
The code is incorrect for some cases when there are different numbers
of components on each side. Also, the control flow in the loop body is
more complex than it needs to be.
This commit simplifies the control flow, fixes the comparison bugs and
adds some extra tests to cover these cases.
* src/abg-tools-utils.cc (decl_names_equal): Move {l,r}_pos2
declarations into the loop and make {l,r}_length const. Avoid
chance of arithmetic on string::npos values. Rework
logic so there is a single test for "names compare equal" and
a single test for different numbers of name components.
* tests/test-tools-utils.cc (main): Add nine more tests.
Signed-off-by: Giuliano Procida <gprocida@google.com>
101 lines
3.6 KiB
C++
101 lines
3.6 KiB
C++
// -*- Mode: C++ -*-
|
|
//
|
|
// Copyright (C) 2013-2020 Red Hat, Inc.
|
|
//
|
|
// This file is part of the GNU Application Binary Interface Generic
|
|
// Analysis and Instrumentation Library (libabigail). This library is
|
|
// free software; you can redistribute it and/or modify it under the
|
|
// terms of the GNU Lesser General Public License as published by the
|
|
// Free Software Foundation; either version 3, or (at your option) any
|
|
// later version.
|
|
|
|
// This library is distributed in the hope that it will be useful, but
|
|
// WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
// General Lesser Public License for more details.
|
|
|
|
// You should have received a copy of the GNU Lesser General Public
|
|
// License along with this program; see the file COPYING-LGPLV3. If
|
|
// not, see <http://www.gnu.org/licenses/>.
|
|
|
|
/// @file
|
|
///
|
|
/// This is a collection of unit tests for functions defined in
|
|
/// abg-tgools-utils.cc.
|
|
|
|
#include <iostream>
|
|
#include "abg-tools-utils.h"
|
|
|
|
using namespace abigail::tools_utils;
|
|
using std::cerr;
|
|
|
|
int
|
|
main(int, char**)
|
|
{
|
|
|
|
/// These are unit tests for abigail::tools_utils::decl_names_equal.
|
|
/// Just run the resulting runtesttoolsutils program under the
|
|
/// debugger to debug this if need be.
|
|
|
|
ABG_ASSERT(decl_names_equal("foo", "foo") == true);
|
|
|
|
ABG_ASSERT(decl_names_equal("foo", "bar") == false);
|
|
|
|
ABG_ASSERT(decl_names_equal("__anonymous_struct__1::foo",
|
|
"__anonymous_struct__2::foo") == true);
|
|
|
|
ABG_ASSERT(decl_names_equal
|
|
("__anonymous_struct__1::foo::__anonymous_struct__2::bar",
|
|
"__anonymous_struct__10::foo::__anonymous_struct__11::bar")
|
|
== true);
|
|
|
|
ABG_ASSERT(decl_names_equal
|
|
("__anonymous_union__1::foo::__anonymous_union__2::bar",
|
|
"__anonymous_union__10::foo::__anonymous_union__11::bar")
|
|
== true);
|
|
|
|
ABG_ASSERT(decl_names_equal
|
|
("__anonymous_enum__1::foo::__anonymous_enum__2::bar",
|
|
"__anonymous_enum__10::foo::__anonymous_enum__11::bar")
|
|
== true);
|
|
|
|
ABG_ASSERT(decl_names_equal
|
|
("__anonymous_struct__1::bar::__anonymous_struct__2::baz",
|
|
"__anonymous_struct__10::foo::__anonymous_struct__11::bar")
|
|
== false);
|
|
|
|
ABG_ASSERT(decl_names_equal
|
|
("__anonymous_struct__1::foo::__anonymous_struct__2::baz",
|
|
"__anonymous_struct__10::foo::__anonymous_struct__11::bar")
|
|
== false);
|
|
|
|
ABG_ASSERT(decl_names_equal
|
|
("__anonymous_struct__1::foo::__anonymous_struct__2::bar",
|
|
"__anonymous_struct__10::foo::__anonymous_union__11::bar")
|
|
== false);
|
|
|
|
ABG_ASSERT(decl_names_equal
|
|
("__anonymous_struct__1::foo::__anonymous_struct__2::bar",
|
|
"__anonymous_struct__10::foo::__anonymous_enum__11::bar")
|
|
== false);
|
|
|
|
ABG_ASSERT(decl_names_equal
|
|
("OT::Extension<OT::ExtensionSubst>::__anonymous_union__",
|
|
"OT::Extension<OT::ExtensionSubst>::__anonymous_union__")
|
|
== true);
|
|
|
|
ABG_ASSERT(decl_names_equal("S0::m2", "S0::m12") == false);
|
|
|
|
ABG_ASSERT(!decl_names_equal("S0::S1", "S0"));
|
|
ABG_ASSERT(!decl_names_equal("S0", "S0::S1"));
|
|
ABG_ASSERT(!decl_names_equal("S1::S0", "S0::S1"));
|
|
ABG_ASSERT(!decl_names_equal("__anonymous_struct__::S0", "__anonymous_struct__"));
|
|
ABG_ASSERT(!decl_names_equal("__anonymous_struct__", "__anonymous_struct__::S1"));
|
|
ABG_ASSERT(!decl_names_equal("__anonymous_struct__::S0", "__anonymous_struct__::S1"));
|
|
ABG_ASSERT(!decl_names_equal("S0::__anonymous_struct__", "__anonymous_struct__"));
|
|
ABG_ASSERT(!decl_names_equal("__anonymous_struct__", "S1::__anonymous_struct__"));
|
|
ABG_ASSERT(!decl_names_equal("S0::__anonymous_struct__", "S1::__anonymous_struct__"));
|
|
|
|
return 0;
|
|
}
|