mirror of
git://sourceware.org/git/libabigail.git
synced 2025-03-06 06:37:31 +00:00
1dcdd54d54
Sometimes when a symbol S' of a function F' aliases the symbol S of a function F, the ABIXML reader might not add F' back into the set of exported functions of the ABI corpus (as the DWARF reader has done initially). That results in the apparent 'loss' of F' (and S') from the corpus. This is due to the way F' is identified, using function_decl::get_id. In the case where the symbol S' of F' has aliases, function_decl::get_id (wrongly) uses the linkage name of F' as the identifier. If F' and F happen to have the same linkage name and if F is already in the set of exported functions of the corpus then F' won't be added into that set. To solve that problem, this patch makes function_decl::get_id construct an ID that ensures that F and F' always have different IDs. * src/abg-ir.cc (function_decl::get_id): If the elf symbol has aliases, make the function name be part of the ID so that this ID differs from the one of the other functions that share a symbol alias with this one. * tests/data/test-abidiff/test-PR18791-report0.txt: Adjust. * tests/data/test-diff-dwarf/test42-PR21296-clanggcc-report0.txt: Likewise. * tests/data/test-diff-filter/test31-pr18535-libstdc++-report-0.txt: Likewise. * tests/data/test-diff-filter/test31-pr18535-libstdc++-report-1.txt: Likewise. * tests/data/test-diff-filter/test41-report-0.txt: Likewise. * tests/data/test-read-dwarf/test10-pr18818-gcc.so.abi: Likewise. * tests/data/test-read-dwarf/test16-pr18904.so.abi: Likewise. * tests/data/test-diff-pkg/glibc-2.32-3.fc33.aarch64-self-check-report-0.txt: New test reference output. * tests/data/test-diff-pkg/glibc-2.32-3.fc33.aarch64.rpm: New test input RPM. * tests/data/test-diff-pkg/glibc-debuginfo-2.32-3.fc33.aarch64.rpm: Likewise. * tests/data/Makefile.am: Add the new test material to source distribution. * tests/test-diff-pkg.cc (in_out_specs): Add the new test input RPMs to this test harness. Signed-off-by: Dodji Seketeli <dodji@redhat.com> |
||
|---|---|---|
| .. | ||
| data | ||
| lib | ||
| .gitignore | ||
| Makefile.am | ||
| mockfedabipkgdiff.in | ||
| print-diff-tree.cc | ||
| runtestcanonicalizetypes.sh.in | ||
| runtestdefaultsupprs.py.in | ||
| runtestdefaultsupprspy3.sh.in | ||
| runtestfedabipkgdiff.py.in | ||
| runtestfedabipkgdiffpy3.sh.in | ||
| runtestslowselfcompare.sh.in | ||
| test-abicompat.cc | ||
| test-abidiff-exit.cc | ||
| test-abidiff.cc | ||
| test-alt-dwarf-file.cc | ||
| test-annotate.cc | ||
| test-core-diff.cc | ||
| test-cxx-compat.cc | ||
| test-diff2.cc | ||
| test-diff-dwarf-abixml.cc | ||
| test-diff-dwarf.cc | ||
| test-diff-filter.cc | ||
| test-diff-pkg.cc | ||
| test-diff-suppr.cc | ||
| test-dot.cc | ||
| test-elf-helpers.cc | ||
| test-ini.cc | ||
| test-ir-walker.cc | ||
| test-kmi-whitelist.cc | ||
| test-lookup-syms.cc | ||
| test-read-dwarf.cc | ||
| test-read-write.cc | ||
| test-svg.cc | ||
| test-symtab.cc | ||
| test-tools-utils.cc | ||
| test-types-stability.cc | ||
| test-utils.cc | ||
| test-utils.h | ||
| test-valgrind-suppressions.supp | ||
| test-write-read-archive.cc | ||
| update-test-output.py | ||