mirror of
git://sourceware.org/git/libabigail.git
synced 2024-12-15 14:34:38 +00:00
The Git repository of the Libabigail Project
194a3029bd
maybe_report_diff_for_symbol() has a few issues: 1. The responsibility for newline emission is somewhat unclear and indeed it would emit spurious blank lines before most of the sub-diffs it reports. 2. Different sub-diff text and terminal commas are emitted according to whether or not there had been a previous sub-diff - making the output harder to grep and post-process. 3. The function also returns a bool but that return value is never used. Hence, change the function to return void, the function stanzas to always emit newline-terminated lines and ensure the wording and punctuation of each sub-diff do not vary. This also tweaks (shortens) the wording used for CRC diffs. * src/abg-reporter-priv.cc (maybe_report_diff_for_symbol): Make return void. Simplify and fix new-line emission. Remove comma emission. Tweak CRC wording. * src/abg-reporter-priv.h (maybe_report_diff_for_symbol): Return void. * tests/data/test-abidiff-exit/test-crc-report.txt: Shorten CRC wording. * tests/data/test-abidiff/test-crc-report.txt: Likewise. * tests/data/test-diff-filter/test-PR27569-report-0.txt: Likewise. Reviewed-by: Giuliano Procida <gprocida@google.com> Signed-off-by: Matthias Maennich <maennich@google.com> |
||
|---|---|---|
| autoconf-archive | ||
| bash-completion | ||
| doc | ||
| include | ||
| m4 | ||
| relicensing-scripts | ||
| scripts | ||
| src | ||
| tests | ||
| tools | ||
| .clang-format | ||
| .gitignore | ||
| .mailmap | ||
| abigail.m4 | ||
| ABIXML-FORMAT-VERSIONS | ||
| AUTHORS | ||
| ChangeLog | ||
| COMMIT-LOG-GUIDELINES | ||
| COMPILING | ||
| configure.ac | ||
| CONTRIBUTING | ||
| default.abignore | ||
| gen-changelog.py | ||
| install-sh | ||
| libabigail.pc.in | ||
| license-change-2020.txt | ||
| LICENSE.txt | ||
| ltmain.sh | ||
| Makefile.am | ||
| NEWS | ||
| README | ||
| release-text-template.txt | ||
| update-copyright.sh | ||
| VISIBILITY | ||
This is the Application Binary Interface Generic Analysis and Instrumentation Library. It aims at constructing, manipulating, serializing and de-serializing ABI-relevant artifacts. The set of artifacts that we are intersted is made of quantities like types, variable, fonctions and declarations of a given library or program. For a given library or program this set of quantities is called an ABI corpus. This library aims at (among other things) providing a way to compare two ABI Corpora (apparently the plural of corpus is copora, heh, that's cool), provide detailed information about their differences, and help build tools to infer interesting conclusions about these differences. You are welcome to contribute to this project after reading the files CONTRIBUTING and COMMIT-LOG-GUIDELINES files in the source tree. Communicating with the maintainers of this project -- including sending patches to be include to the source code -- happens via email at libabigail@sourceware.org.