mirror of
git://sourceware.org/git/libabigail.git
synced 2025-03-04 21:57:42 +00:00
43cbdd1501
Today, the pointer-to-void type is naively considered as being
different to all other pointers by Libabigail. This indirectly leads
to spurious changes in code bases where we have this kind of pattern:
/* in foo.h */
typedef void* some_pointer_type;
struct foo
{
some_pointer_type member;
};
bool
test_some_pointer_type(some_pointer_type);
/* This header file is included by client code */
/*in foo.c */
typedef int* some_pointer_type;
struct foo
{
some_pointer_type member;
};
bool
test_some_pointer_type(some_pointer_type f)
{
/* The actual implementation. */
}
Another way to reproduce that spurious change is to run this command:
$ fedabipkgdiff --self-compare -a --from fc37 glibc
* include/abg-fwd.h (is_void_pointer_type): Declare new function.
* src/abg-ir.cc (is_void_pointer_type): Define new function.
(equals): In the overload for pointer_type_def, handle the special
case pointer to void, making it equal to all other pointer, for
the C language.
(is_non_canonicalized_type): pointer to void is no more
canonicalized as it can be equal to all other types.
* tests/data/test-annotate/libtest23.so.abi: Adjust
* tests/data/test-annotate/libtest24-drop-fns-2.so.abi: Likewise.
* tests/data/test-annotate/libtest24-drop-fns.so.abi: Likewise.
* tests/data/test-annotate/test1.abi: Likewise.
* tests/data/test-annotate/test13-pr18894.so.abi: Likewise.
* tests/data/test-annotate/test14-pr18893.so.abi: Likewise.
* tests/data/test-annotate/test15-pr18892.so.abi: Likewise.
* tests/data/test-annotate/test17-pr19027.so.abi: Likewise.
* tests/data/test-annotate/test18-pr19037-libvtkRenderingLIC-6.1.so.abi:
Likewise.
* tests/data/test-annotate/test19-pr19023-libtcmalloc_and_profiler.so.abi:
Likewise.
* tests/data/test-annotate/test20-pr19025-libvtkParallelCore-6.1.so.abi:
Likewise.
* tests/data/test-annotate/test21-pr19092.so.abi: Likewise.
* tests/data/test-annotate/test5.o.abi: Likewise.
* tests/data/test-diff-filter/test31-pr18535-libstdc++-report-1.txt:
Likewise.
* tests/data/test-diff-filter/test47-filter-void-ptr-change-report-0.txt:
Likewise.
* tests/data/test-read-dwarf/PR22015-libboost_iostreams.so.abi:
Likewise.
* tests/data/test-read-dwarf/PR22122-libftdc.so.abi: Likewise.
* tests/data/test-read-dwarf/PR25007-sdhci.ko.abi: Likewise.
* tests/data/test-read-dwarf/PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi:
Likewise.
* tests/data/test-read-dwarf/libtest23.so.abi: Likewise.
* tests/data/test-read-dwarf/libtest24-drop-fns-2.so.abi: Likewise.
* tests/data/test-read-dwarf/libtest24-drop-fns.so.abi: Likewise.
* tests/data/test-read-dwarf/test-libaaudio.so.abi: Likewise.
* tests/data/test-read-dwarf/test-libandroid.so.abi: Likewise.
* tests/data/test-read-dwarf/test1.abi: Likewise.
* tests/data/test-read-dwarf/test1.hash.abi: Likewise.
* tests/data/test-read-dwarf/test10-pr18818-gcc.so.abi: Likewise.
* tests/data/test-read-dwarf/test11-pr18828.so.abi: Likewise.
* tests/data/test-read-dwarf/test12-pr18844.so.abi: Likewise.
* tests/data/test-read-dwarf/test13-pr18894.so.abi: Likewise.
* tests/data/test-read-dwarf/test14-pr18893.so.abi: Likewise.
* tests/data/test-read-dwarf/test15-pr18892.so.abi: Likewise.
* tests/data/test-read-dwarf/test16-pr18904.so.abi: Likewise.
* tests/data/test-read-dwarf/test17-pr19027.so.abi: Likewise.
* tests/data/test-read-dwarf/test18-pr19037-libvtkRenderingLIC-6.1.so.abi: Likewise.
* tests/data/test-read-dwarf/test19-pr19023-libtcmalloc_and_profiler.so.abi: Likewise.
* tests/data/test-read-dwarf/test20-pr19025-libvtkParallelCore-6.1.so.abi:
Likewise.
* tests/data/test-read-dwarf/test21-pr19092.so.abi: Likewise.
* tests/data/test-read-dwarf/test22-pr19097-libstdc++.so.6.0.17.so.abi:
Likewise.
* tests/data/test-read-dwarf/test5.o.abi: Likewise.
* tests/data/test-read-dwarf/test5.o.hash.abi: Likewise.
* tests/data/test-read-dwarf/test9-pr18818-clang.so.abi: Likewise.
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
|
||
|---|---|---|
| .. | ||
| PR26261 | ||
| PR27700 | ||
| PR28584 | ||
| libtest23.so | ||
| libtest23.so.abi | ||
| libtest24-drop-fns-2.so.abi | ||
| libtest24-drop-fns.so | ||
| libtest24-drop-fns.so.abi | ||
| PR22015-libboost_iostreams.so | ||
| PR22015-libboost_iostreams.so.abi | ||
| PR22122-libftdc.so | ||
| PR22122-libftdc.so.abi | ||
| PR24378-fn-is-not-scope.abi | ||
| PR24378-fn-is-not-scope.o | ||
| PR25007-sdhci.ko | ||
| PR25007-sdhci.ko.abi | ||
| PR25042-libgdbm-clang-dwarf5.so.6.0.0 | ||
| PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi | ||
| PR29443-missing-xx.cc | ||
| PR29443-missing-xx.o | ||
| PR29443-missing-xx.o.abi | ||
| PR29692-kdelibs3-libkjava.so.1.0.0 | ||
| PR29692-kdelibs3-libkjava.so.1.0.0.abi | ||
| test0 | ||
| test0.abi | ||
| test0.cc | ||
| test0.hash.abi | ||
| test1 | ||
| test1.abi | ||
| test1.cc | ||
| test1.hash.abi | ||
| test2-0.cc | ||
| test2-1.cc | ||
| test2.h | ||
| test2.so | ||
| test2.so.abi | ||
| test2.so.hash.abi | ||
| test3-alias-1.so.hash.abi | ||
| test3-alias-2.so.hash.abi | ||
| test3-alias-3.so.hash.abi | ||
| test3-alias-4.so.hash.abi | ||
| test3.so.abi | ||
| test3.so.hash.abi | ||
| test4.so.abi | ||
| test4.so.hash.abi | ||
| test5.cc | ||
| test5.o | ||
| test5.o.abi | ||
| test5.o.hash.abi | ||
| test6.cc | ||
| test6.so | ||
| test6.so.abi | ||
| test6.so.hash.abi | ||
| test7.cc | ||
| test7.so | ||
| test7.so.abi | ||
| test7.so.hash.abi | ||
| test8-qualified-this-pointer.cc | ||
| test8-qualified-this-pointer.so | ||
| test8-qualified-this-pointer.so.abi | ||
| test8-qualified-this-pointer.so.hash.abi | ||
| test9-pr18818-clang.so | ||
| test9-pr18818-clang.so.abi | ||
| test10-pr18818-gcc.so | ||
| test10-pr18818-gcc.so.abi | ||
| test11-pr18828.so | ||
| test11-pr18828.so.abi | ||
| test12-pr18844.so | ||
| test12-pr18844.so.abi | ||
| test13-pr18894.so | ||
| test13-pr18894.so.abi | ||
| test14-pr18893.so | ||
| test14-pr18893.so.abi | ||
| test15-pr18892.so | ||
| test15-pr18892.so.abi | ||
| test16-pr18904.so | ||
| test16-pr18904.so.abi | ||
| test17-pr19027.so | ||
| test17-pr19027.so.abi | ||
| test18-pr19037-libvtkRenderingLIC-6.1.so | ||
| test18-pr19037-libvtkRenderingLIC-6.1.so.abi | ||
| test19-pr19023-libtcmalloc_and_profiler.so | ||
| test19-pr19023-libtcmalloc_and_profiler.so.abi | ||
| test20-pr19025-libvtkParallelCore-6.1.so | ||
| test20-pr19025-libvtkParallelCore-6.1.so.abi | ||
| test21-pr19092.so | ||
| test21-pr19092.so.abi | ||
| test22-pr19097-libstdc++.so.6.0.17.so | ||
| test22-pr19097-libstdc++.so.6.0.17.so.abi | ||
| test23-first-tu.cc | ||
| test23-second-tu.cc | ||
| test24-drop-fns-0.suppr | ||
| test24-drop-fns.cc | ||
| test25-bogus-binary.elf | ||
| test26-bogus-binary.elf | ||
| test27-bogus-binary.elf | ||
| test-fallback.abi | ||
| test-fallback.c | ||
| test-fallback.o | ||
| test-libaaudio.so | ||
| test-libaaudio.so.abi | ||
| test-libandroid.so | ||
| test-libandroid.so.abi | ||
| test-PR26568-1.o.abi | ||
| test-PR26568-2.o.abi | ||
| test-suppressed-alias.c | ||
| test-suppressed-alias.o | ||
| test-suppressed-alias.o.abi | ||
| test-suppressed-alias.suppr | ||