RepoMirrors/libabigail
1
0
Fork 0
mirror of git://sourceware.org/git/libabigail.git synced 2025-03-06 22:58:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use abidw --abidiff in test-read-dwarf.cc

Browse Source 
That test was doing several sub-tests that amount to just calling
abidw --abidiff.  So, let's use that, now that we have it.

	* tests/test-read-dwarf.cc (handle_in_out_spec): Rather than
	calling abilint on the abixml and abidiff-ing the .so file against
	its .so.abi, call abidw --abidiff on the .so file and voila.  Ok,
	it does one extra save of abixml, but then that won't hurt.  And
	things are faster now than what they were anyway :-)

Signed-off-by: Dodji Seketeli <dodji@redhat.com>
This commit is contained in:
Dodji Seketeli 2015-10-17 15:06:57 +02:00
parent 8cc382c881
commit f6556681d0
1 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tests/test-read-dwarf.cc
View File

@ -246,17 +246,8 @@ handle_in_out_spec(void)
pthread_mutex_unlock(&write_lock);
of.close();
string abilint = get_build_dir() + "/tools/abilint";
abilint += " --noout";
string cmd = abilint + " " + out_abi_path;
if (system(cmd.c_str()))
{
cerr << "output file doesn't pass abilint: " << out_abi_path << "\n";
is_ok = false;
}
string abidiff = get_build_dir() + "/tools/abidiff";
cmd = abidiff + " --no-architecture " + in_elf_path + " " + out_abi_path;
string abidw = get_build_dir() + "/tools/abidw";
string cmd = abidw + " --abidiff " + in_elf_path;
if (system(cmd.c_str()))
{
cerr << "ABIs differ:\n"