RepoMirrors/libabigail
1
0
Fork 0
mirror of git://sourceware.org/git/libabigail.git synced 2025-01-01 23:12:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't walk the diff tree when there are no suppressions

Browse Source 
Profiling showed that we were walking the diff tree to apply
suppressions even when there were no suppressions to apply.  This
patch does away with that behaviour.

	* src/abg-comparison.cc (apply_suppressions): Do not walk the diff
	tree to apply suppressions when there are no suppressions to
	apply.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>
This commit is contained in:
Dodji Seketeli 2015-02-07 10:31:32 +01:00
parent 6fa1dca62a
commit c27ec0db35
1 changed files with 16 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/abg-comparison.cc
View File

@ -12127,11 +12127,14 @@ struct suppression_categorization_visitor : public diff_node_visitor
void
apply_suppressions(diff* diff_tree)
{
suppression_categorization_visitor v;
bool s = diff_tree->context()->visiting_a_node_twice_is_forbidden();
diff_tree->context()->forbid_visiting_a_node_twice(false);
diff_tree->traverse(v);
diff_tree->context()->forbid_visiting_a_node_twice(s);
if (diff_tree && !diff_tree->context()->suppressions().empty())
{
suppression_categorization_visitor v;
bool s = diff_tree->context()->visiting_a_node_twice_is_forbidden();
diff_tree->context()->forbid_visiting_a_node_twice(false);
diff_tree->traverse(v);
diff_tree->context()->forbid_visiting_a_node_twice(s);
}
}
/// Walk a given diff-sub tree and appply the suppressions carried by
@ -12153,11 +12156,14 @@ apply_suppressions(diff_sptr diff_tree)
void
apply_suppressions(const corpus_diff* diff_tree)
{
suppression_categorization_visitor v;
bool s = diff_tree->context()->visiting_a_node_twice_is_forbidden();
diff_tree->context()->forbid_visiting_a_node_twice(false);
const_cast<corpus_diff*>(diff_tree)->traverse(v);
diff_tree->context()->forbid_visiting_a_node_twice(s);
if (diff_tree && !diff_tree->context()->suppressions().empty())
{
suppression_categorization_visitor v;
bool s = diff_tree->context()->visiting_a_node_twice_is_forbidden();
diff_tree->context()->forbid_visiting_a_node_twice(false);
const_cast<corpus_diff*>(diff_tree)->traverse(v);
diff_tree->context()->forbid_visiting_a_node_twice(s);
}
}
/// Walk a diff tree and appply the suppressions carried by the