RepoMirrors/libabigail
1
0
Fork 0
mirror of git://sourceware.org/git/libabigail.git synced 2025-03-06 22:58:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not use recursive type hashing when writing out function types

Browse Source 
When the abixml writer emits function types, it puts function
types that are referenced by pointers or references into a map on the
side.  Unfortunately, that map hashes types by recursively calculating
a progressive hash value.  That is dog slow and we avoid that
throughout the code base.

This patch changes that to use the numerical values of the canonical
type pointer of the function type as a hash, making abixml fast again,
again on big library as libmozjs.so.

	* src/abg-writer.cc (typedef fn_shared_ptr_map): Remove.
	(write_context::m_referenced_fntypes_map): Change the type of this
	into type_ptr_map.
	(write_context::{record_fntype_as_referenced,
	fntype_is_referenced}): Use the pointer value of the canonical
	type of the referenced type as key for the map.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>
This commit is contained in:
Dodji Seketeli 2015-10-02 19:42:12 +02:00
parent 501c514245
commit 8b76f6c34e
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/abg-writer.cc
View File

@ -117,11 +117,6 @@ typedef unordered_map<type_base*,
type_hasher,
abigail::diff_utils::deep_ptr_eq_functor> type_ptr_map;
/// A convenience typedef for a map that associates a shared pointer to a bool.
typedef unordered_map<shared_ptr<type_base>,
bool,
type_base::shared_ptr_hash> fn_shared_ptr_map;
typedef unordered_map<shared_ptr<function_tdecl>,
string,
function_tdecl::shared_ptr_hash> fn_tmpl_shared_ptr_map;
@ -140,7 +135,7 @@ class write_context
/// A vector of function types that are referenced by emitted pointers
/// or reference, i.e, that are pointed-to types of pointers or references
/// that are emitted.
fn_shared_ptr_map m_referenced_fntypes_map;
type_ptr_map m_referenced_fntypes_map;
fn_tmpl_shared_ptr_map m_fn_tmpl_id_map;
class_tmpl_shared_ptr_map m_class_tmpl_id_map;
string_elf_symbol_sptr_map_type m_fun_symbol_map;
@ -245,7 +240,7 @@ public:
/// @param f a shared pointer to a function type
void
record_fntype_as_referenced(const function_type_sptr& f)
{m_referenced_fntypes_map[f->get_canonical_type()] = true;}
{m_referenced_fntypes_map[f->get_canonical_type().get()] = true;}
/// Test if a given function type has been referenced by
/// a pointer or a reference type that was emitted to the
@ -257,7 +252,10 @@ public:
/// otherwise.
bool
fntype_is_referenced(const function_type_sptr& f)
{return m_referenced_fntypes_map.find(f->get_canonical_type()) != m_referenced_fntypes_map.end();}
{
return m_referenced_fntypes_map.find
(f->get_canonical_type().get()) != m_referenced_fntypes_map.end();
}
/// Flag a type as having been written out to the XML output.
///