From 86d319dc08953b11bc80d7d73ca9ab23b0c0c717 Mon Sep 17 00:00:00 2001 From: Dodji Seketeli Date: Thu, 13 Mar 2014 13:59:33 +0100 Subject: [PATCH] Do not report change in typedef underlying type is there is none * src/abg-comparison.cc (typedef_diff::report): Do not forget to check the length of the diff of the underlying type before sending its diff report down the wire. Signed-off-by: Dodji Seketeli --- src/abg-comparison.cc | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/abg-comparison.cc b/src/abg-comparison.cc index 4869ba4e..d128ebc7 100644 --- a/src/abg-comparison.cc +++ b/src/abg-comparison.cc @@ -4036,14 +4036,15 @@ typedef_diff::report(ostream& out, const string& indent) const emit_nl = true; } - if (diff_sptr d = underlying_type_diff()) + diff_sptr d = underlying_type_diff(); + if (d && d->length()) { if (diff_sptr d2 = context()->has_diff_for(d)) { if (d2->currently_reporting()) - out << indent << "underlying type '" - << d->first_subject()->get_pretty_representation() - << "' changed; details are being reported\n"; + out << indent << "underlying type '" + << d->first_subject()->get_pretty_representation() + << "' changed; details are being reported\n"; else if (d2->reported_once()) out << indent << "underlying type '" << d->first_subject()->get_pretty_representation()