RepoMirrors/libabigail
1
0
Fork 0
mirror of git://sourceware.org/git/libabigail.git synced 2024-12-16 15:04:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't iterate before the start of a RandomAccessOutputIterator.

Browse Source 
Found with -D_GLIBCXX_DEBUG. You cannot go before the start of an
RandomAccessOutputIterator. Iterator -1 + 1 might seem to work,
but is actually undefined behaviour.

	* include/abg-diff-utils.h (compute_diff): Put brackets around
	p[ux].[xy]() + 1 calculation.

Signed-off-by: Mark Wielaard <mark@klomp.org>
This commit is contained in:
Mark Wielaard 2020-05-11 18:55:03 +02:00 committed by Dodji Seketeli
parent f7a85ec9d0
commit 66e5e36469
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
include/abg-diff-utils.h
View File

@ -1591,8 +1591,8 @@ compute_diff(RandomAccessOutputIterator a_base,
point px, pu;
snake_end_points(snak, px, pu);
compute_diff<RandomAccessOutputIterator,
EqualityFunctor>(a_base, a_begin, a_base + px.x() + 1,
b_base, b_begin, b_base + px.y() + 1,
EqualityFunctor>(a_base, a_begin, a_base + (px.x() + 1),
b_base, b_begin, b_base + (px.y() + 1),
lcs, tmp_ses0, tmp_ses_len0);
lcs.insert(lcs.end(), trace.begin(), trace.end());
@ -1600,8 +1600,8 @@ compute_diff(RandomAccessOutputIterator a_base,
int tmp_ses_len1 = 0;
edit_script tmp_ses1;
compute_diff<RandomAccessOutputIterator,
EqualityFunctor>(a_base, a_base + pu.x() + 1, a_end,
b_base, b_base + pu.y() + 1, b_end,
EqualityFunctor>(a_base, a_base + (pu.x() + 1), a_end,
b_base, b_base + (pu.y() + 1), b_end,
lcs, tmp_ses1, tmp_ses_len1);
ABG_ASSERT(tmp_ses0.length() + tmp_ses1.length() == d);
ABG_ASSERT(tmp_ses_len0 + tmp_ses_len1 == d);